Re: [PATCH 04/20] KVM: selftests: Rename "num" param to "nr_pages" for physical page allocators

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Typo in the new comment introduces missing and incorrect words, making the sentence confusing.
--

commit 98eb73af6590845b3086e8d4eb766da617c1c334
Author: Sean Christopherson <seanjc@google.com>

KVM: selftests: Rename "num" param to "nr_pages" for physical page allocators

This commit renames the "num" parameter to "nr_pages" in the physical page
allocator APIs to clarify the parameter's role. It also updates the function
comment for __vm_phy_pages_alloc() to drop kerneldoc style and explicitly
state that success is guaranteed.

> diff --git a/tools/testing/selftests/kvm/lib/kvm_util.c b/tools/testing/selftests/kvm/lib/kvm_util.c
> index 9ddc047d5c275..b071d77dd301f 100644
> --- a/tools/testing/selftests/kvm/lib/kvm_util.c
> +++ b/tools/testing/selftests/kvm/lib/kvm_util.c
[ ... ]
> @@ -2025,33 +2025,20 @@ const char *exit_reason_str(unsigned int exit_reason)
>  }
>  
>  /*
> - * Physical Contiguous Page Allocator
> + * Allocate contiguous (guest) physical pages in a given memory region, at or
> + * the minimum specific GPA.  If the memory is protected/private, also add the
> + * allocate pages to the region's set of protected pages, e.g. so that arch

[Severity: Low]
This isn't a bug, but there appear to be grammatical issues in the newly
added comment block for __vm_phy_pages_alloc().

Could "at or the minimum" be "at or above the minimum", and "allocate pages"
be "allocated pages"?

> + * code knows which pages need to be encrypted when launching the VM.
> + *
> + * Note, success is guaranteed!
>   */
> -gpa_t __vm_phy_pages_alloc(struct kvm_vm *vm, size_t num,
> -			   gpa_t min_gpa, u32 memslot,
> -			   bool protected)
> +gpa_t __vm_phy_pages_alloc(struct kvm_vm *vm, size_t nr_pages, gpa_t min_gpa,
> +			   u32 memslot, bool protected)

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260826230511.972824-1-seanjc@google.com?part=4