Re: [PATCH 19/20] KVM: selftests: Automatically pick min_gpa for allocations based on region type

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The static global variable `gpa_base` is no longer used outside of `setup_memslot()` after this patch and should be converted to a local variable.
--

commit 1b35d93b3db739cce7476eddad2ce87d3cb799ed
Author: Sean Christopherson <seanjc@google.com>

KVM: selftests: Automatically pick min_gpa for allocations based on region type

This patch modifies the memory allocation logic to automatically choose the
minimum GPA for physical page allocations based on the region type. It
streamlines how minimum GPAs are handled across various wrappers and tests
by categorizing them into default minimums, page tables, and custom memslots.

> diff --git a/tools/testing/selftests/kvm/arm64/vgic_lpi_stress.c b/tools/testing/selftests/kvm/arm64/vgic_lpi_stress.c
> index a45c0849a47a9..b4c651ea385d8 100644
> --- a/tools/testing/selftests/kvm/arm64/vgic_lpi_stress.c
> +++ b/tools/testing/selftests/kvm/arm64/vgic_lpi_stress.c
> @@ -191,28 +191,25 @@ static void setup_test_data(void)
>  	gpa_t cmdq_base;
>  
>  	test_data.device_table = vm_phy_pages_alloc(vm, pages_per_64k,
> -						    gpa_base,
>  						    MEM_REGION_TEST_EXTRA);

[Severity: Low]
Does this change leave the static global variable gpa_base with no uses outside
of setup_memslot()?

Since it is no longer used here in setup_test_data(), could it be converted to
a local variable where it is still used?

tools/testing/selftests/kvm/arm64/vgic_lpi_stress.c:setup_memslot() {
	...
	gpa_base = ((vm_compute_max_gfn(vm) + 1) * vm->page_size) - sz;
	vm_override_mem_region(vm, MEM_REGION_TEST_EXTRA, VM_MEM_SRC_ANONYMOUS,
			       gpa_base, TEST_MEMSLOT_INDEX, pages);
	...
}

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260826230511.972824-1-seanjc@google.com?part=19