Re: [PATCH v2 02/28] KVM: Define and communicate KVM_EXIT_MEMORY_FAULT RWX flags to userspace

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] kvm: missing mirror sync in tools/include/uapi/linux/kvm.h for memory exit flags
--

commit bde51f2cf0c01c45785fd4f593b721d8c5b218c8
Author: Anish Moorthy <amoorthy@google.com>

KVM: Define and communicate KVM_EXIT_MEMORY_FAULT RWX flags to userspace

This commit adds new read, write, and execute flags to the
KVM_EXIT_MEMORY_FAULT UAPI structure to communicate the faulting access
type to userspace.

Link: https://lore.kernel.org/kvm/ZR4N8cwzTMDanPUY@google.com/

[ ... ]

> diff --git a/include/uapi/linux/kvm.h b/include/uapi/linux/kvm.h
> index ac2d77d149635..15a3090f067e5 100644
> --- a/include/uapi/linux/kvm.h
> +++ b/include/uapi/linux/kvm.h
> @@ -457,6 +457,9 @@ struct kvm_run {
>  		} notify;
>  		/* KVM_EXIT_MEMORY_FAULT */
>  		struct {
> +#define KVM_MEMORY_EXIT_FLAG_READ       (1ULL << 0)
> +#define KVM_MEMORY_EXIT_FLAG_WRITE      (1ULL << 1)
> +#define KVM_MEMORY_EXIT_FLAG_EXEC       (1ULL << 2)
>  #define KVM_MEMORY_EXIT_FLAG_PRIVATE	(1ULL << 3)

[Severity: Low]
Does this patch also need to sync the mirrored UAPI header in
tools/include/uapi/linux/kvm.h?

The new KVM_MEMORY_EXIT_FLAG_READ, KVM_MEMORY_EXIT_FLAG_WRITE, and
KVM_MEMORY_EXIT_FLAG_EXEC macros are missing from the tools directory
copy of the UAPI header. This will leave tools building against the
mirrored header without the required definitions.

>  			__u64 flags;
>  			__u64 gpa;

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260918081543.139871-1-pbonzini@redhat.com?part=2