Kernel KVM virtualization development
 help / color / mirror / Atom feed
* [PATCH] Documentation: Add missing KVM s390 crypto attributes
@ 2026-09-18 14:51 Eric Farman
  2026-09-18 14:55 ` sashiko-bot
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Eric Farman @ 2026-09-18 14:51 UTC (permalink / raw)
  To: Tony Krowiak, Paolo Bonzini, Sean Christopherson
  Cc: Jonathan Corbet, Shuah Khan, Randy Dunlap, kvm, linux-doc,
	linux-s390, Eric Farman

Device attributes to enable/disable the AP interpretive execution
support for crypto were added to KVM several years ago, but they
weren't added to the documentation itself.

Fixes: 37940fb0b6a2 ("KVM: s390: device attrs to enable/disable AP interpretation")
Signed-off-by: Eric Farman <farman@linux.ibm.com>
---
 Documentation/virt/kvm/devices/vm.rst | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)

diff --git a/Documentation/virt/kvm/devices/vm.rst b/Documentation/virt/kvm/devices/vm.rst
index a4d39fa1b083..78e63eb9994e 100644
--- a/Documentation/virt/kvm/devices/vm.rst
+++ b/Documentation/virt/kvm/devices/vm.rst
@@ -280,6 +280,24 @@ Allows user space to disable dea key wrapping, clearing the wrapping key.
 :Parameters: none
 :Returns:    0
 
+4.5. ATTRIBUTE: KVM_S390_VM_CRYPTO_ENABLE_APIE (w/o)
+-------------------------------------------------------
+
+Allows user space to enable AP interpretive execution.
+
+:Parameters: none
+:Returns:    0 for success
+	     -EOPNOTSUPP if AP instructions not available for guest
+
+4.6. ATTRIBUTE: KVM_S390_VM_CRYPTO_DISABLE_APIE (w/o)
+-------------------------------------------------------
+
+Allows user space to disable AP interpretive execution.
+
+:Parameters: none
+:Returns:    0 for success
+	     -EOPNOTSUPP if AP instructions not available for guest
+
 5. GROUP: KVM_S390_VM_MIGRATION
 ===============================
 
-- 
2.53.0


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] Documentation: Add missing KVM s390 crypto attributes
  2026-09-18 14:51 [PATCH] Documentation: Add missing KVM s390 crypto attributes Eric Farman
@ 2026-09-18 14:55 ` sashiko-bot
  2026-09-22 11:49 ` Anthony Krowiak
  2026-09-22 13:04 ` Christian Borntraeger
  2 siblings, 0 replies; 4+ messages in thread
From: sashiko-bot @ 2026-09-18 14:55 UTC (permalink / raw)
  To: Eric Farman
  Cc: kvm, Vasily Gorbik, linux-s390, Heiko Carstens, Alexander Gordeev,
	Christian Borntraeger

> Device attributes to enable/disable the AP interpretive execution
> support for crypto were added to KVM several years ago, but they
> weren't added to the documentation itself.
> 
> Fixes: 37940fb0b6a2 ("KVM: s390: device attrs to enable/disable AP interpretation")
> Signed-off-by: Eric Farman <farman@linux.ibm.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260918145151.2116991-1-farman@linux.ibm.com?part=1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] Documentation: Add missing KVM s390 crypto attributes
  2026-09-18 14:51 [PATCH] Documentation: Add missing KVM s390 crypto attributes Eric Farman
  2026-09-18 14:55 ` sashiko-bot
@ 2026-09-22 11:49 ` Anthony Krowiak
  2026-09-22 13:04 ` Christian Borntraeger
  2 siblings, 0 replies; 4+ messages in thread
From: Anthony Krowiak @ 2026-09-22 11:49 UTC (permalink / raw)
  To: Eric Farman, Paolo Bonzini, Sean Christopherson
  Cc: Jonathan Corbet, Shuah Khan, Randy Dunlap, kvm, linux-doc,
	linux-s390



On 9/18/26 10:51 AM, Eric Farman wrote:
> Device attributes to enable/disable the AP interpretive execution
> support for crypto were added to KVM several years ago, but they
> weren't added to the documentation itself.
>
> Fixes: 37940fb0b6a2 ("KVM: s390: device attrs to enable/disable AP interpretation")
> Signed-off-by: Eric Farman <farman@linux.ibm.com>

Reviewed-by: Anthony Krowiak <akrowiak@linux.ibm.com>

> ---
>   Documentation/virt/kvm/devices/vm.rst | 18 ++++++++++++++++++
>   1 file changed, 18 insertions(+)
>
> diff --git a/Documentation/virt/kvm/devices/vm.rst b/Documentation/virt/kvm/devices/vm.rst
> index a4d39fa1b083..78e63eb9994e 100644
> --- a/Documentation/virt/kvm/devices/vm.rst
> +++ b/Documentation/virt/kvm/devices/vm.rst
> @@ -280,6 +280,24 @@ Allows user space to disable dea key wrapping, clearing the wrapping key.
>   :Parameters: none
>   :Returns:    0
>   
> +4.5. ATTRIBUTE: KVM_S390_VM_CRYPTO_ENABLE_APIE (w/o)
> +-------------------------------------------------------
> +
> +Allows user space to enable AP interpretive execution.
> +
> +:Parameters: none
> +:Returns:    0 for success
> +	     -EOPNOTSUPP if AP instructions not available for guest
> +
> +4.6. ATTRIBUTE: KVM_S390_VM_CRYPTO_DISABLE_APIE (w/o)
> +-------------------------------------------------------
> +
> +Allows user space to disable AP interpretive execution.
> +
> +:Parameters: none
> +:Returns:    0 for success
> +	     -EOPNOTSUPP if AP instructions not available for guest
> +
>   5. GROUP: KVM_S390_VM_MIGRATION
>   ===============================
>   


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] Documentation: Add missing KVM s390 crypto attributes
  2026-09-18 14:51 [PATCH] Documentation: Add missing KVM s390 crypto attributes Eric Farman
  2026-09-18 14:55 ` sashiko-bot
  2026-09-22 11:49 ` Anthony Krowiak
@ 2026-09-22 13:04 ` Christian Borntraeger
  2 siblings, 0 replies; 4+ messages in thread
From: Christian Borntraeger @ 2026-09-22 13:04 UTC (permalink / raw)
  To: Eric Farman, Tony Krowiak, Paolo Bonzini, Sean Christopherson
  Cc: Jonathan Corbet, Shuah Khan, Randy Dunlap, kvm, linux-doc,
	linux-s390



Am 18.09.26 um 16:51 schrieb Eric Farman:
> Device attributes to enable/disable the AP interpretive execution
> support for crypto were added to KVM several years ago, but they
> weren't added to the documentation itself.
> 
> Fixes: 37940fb0b6a2 ("KVM: s390: device attrs to enable/disable AP interpretation")
> Signed-off-by: Eric Farman <farman@linux.ibm.com>

thanks. Unless Jonathan objects, I will take that via the kvms390 tree.
> ---
>   Documentation/virt/kvm/devices/vm.rst | 18 ++++++++++++++++++
>   1 file changed, 18 insertions(+)
> 
> diff --git a/Documentation/virt/kvm/devices/vm.rst b/Documentation/virt/kvm/devices/vm.rst
> index a4d39fa1b083..78e63eb9994e 100644
> --- a/Documentation/virt/kvm/devices/vm.rst
> +++ b/Documentation/virt/kvm/devices/vm.rst
> @@ -280,6 +280,24 @@ Allows user space to disable dea key wrapping, clearing the wrapping key.
>   :Parameters: none
>   :Returns:    0
>   
> +4.5. ATTRIBUTE: KVM_S390_VM_CRYPTO_ENABLE_APIE (w/o)
> +-------------------------------------------------------
> +
> +Allows user space to enable AP interpretive execution.
> +
> +:Parameters: none
> +:Returns:    0 for success
> +	     -EOPNOTSUPP if AP instructions not available for guest
> +
> +4.6. ATTRIBUTE: KVM_S390_VM_CRYPTO_DISABLE_APIE (w/o)
> +-------------------------------------------------------
> +
> +Allows user space to disable AP interpretive execution.
> +
> +:Parameters: none
> +:Returns:    0 for success
> +	     -EOPNOTSUPP if AP instructions not available for guest
> +
>   5. GROUP: KVM_S390_VM_MIGRATION
>   ===============================
>   


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2026-09-22 13:05 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-09-18 14:51 [PATCH] Documentation: Add missing KVM s390 crypto attributes Eric Farman
2026-09-18 14:55 ` sashiko-bot
2026-09-22 11:49 ` Anthony Krowiak
2026-09-22 13:04 ` Christian Borntraeger

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox