From: Tao Cui <cui.tao@linux.dev>
To: chenhuacai@kernel.org, maobibo@loongson.cn, zhaotianrui@loongson.cn
Cc: loongarch@lists.linux.dev, kvm@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel@xen0n.name,
nagachaithanya9911@gmail.com, cui.tao@linux.dev,
Tao Cui <cuitao@kylinos.cn>
Subject: [PATCH v4 0/3] LoongArch: KVM: irqchip fixes
Date: Fri, 16 Oct 2026 07:46:35 +0800 [thread overview]
Message-ID: <20261015234638.1077815-1-cui.tao@linux.dev> (raw)
From: Tao Cui <cuitao@kylinos.cn>
Hi,
Three fixes for the LoongArch KVM irqchip code:
- Patch 1 clears the device pointer in the destroy callbacks: when
KVM_CREATE_DEVICE succeeds but the following fd allocation fails
(e.g. under RLIMIT_NOFILE), ops->destroy() frees the irqchip while
kvm->arch.* still points to it.
- Patch 2 aligns kvm_pch_pic_create() with kvm_eiointc_create() by
propagating the real error code; the kvm_ipi_create() counterpart is
being fixed separately (Chaithanya Lagisetty).
- Patch 3 rejects repeated PCH-PIC CTRL_INIT with -EEXIST, using the
initialized state of the kvm_io_device as the indicator. The check,
the MMIO base update and the bus registration are serialized by
slots_lock.
All patches carry Fixes tags.
Changes in v4:
- Patch 3: update pch_pic_base unconditionally, as suggested by
Huacai.
Changes in v3:
- Drop "Load dmsintc pointer once in pch_msi_set_irq" (v2 patch 2),
suggested by Bibo and Huacai.
- Patch 3 (v2 patch 4): reject repeated CTRL_INIT by checking the
kvm_io_device state instead of a separate has_init flag, also
suggested by Huacai; the check stays under slots_lock.
Changes in v2:
- Drop "Guard against NULL irqchip in irq injection" (v1 patch 2) and
"Rebase steal time counter in vcpu context" (v1 patch 4) after
review discussion: their trigger scenarios are not reachable
through real VMM behaviour.
- Use the one-line destroy style in dmsintc suggested by Bibo.
- Track repeated PCH-PIC CTRL_INIT with a has_init flag and return
-EEXIST instead of -EBUSY, also suggested by Bibo; move the check
and base update under slots_lock so they are atomic.
- Add READ_ONCE() to the dmsintc pointer loads so the compiler
keeps each of them a single load.
Tao Cui (3):
LoongArch: KVM: Clear device pointer in irqchip destroy callbacks
LoongArch: KVM: Propagate real error code in kvm_pch_pic_create
LoongArch: KVM: Reject repeated PCH-PIC CTRL_INIT
arch/loongarch/kvm/intc/dmsintc.c | 1 +
arch/loongarch/kvm/intc/eiointc.c | 1 +
arch/loongarch/kvm/intc/ipi.c | 1 +
arch/loongarch/kvm/intc/pch_pic.c | 14 ++++++++++----
4 files changed, 13 insertions(+), 4 deletions(-)
--
2.43.0
next reply other threads:[~2026-10-15 23:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-15 23:46 Tao Cui [this message]
2026-10-15 23:46 ` [PATCH v4 1/3] LoongArch: KVM: Clear device pointer in irqchip destroy callbacks Tao Cui
2026-10-16 0:05 ` sashiko-bot
2026-10-16 1:03 ` Bibo Mao
2026-10-15 23:46 ` [PATCH v4 2/3] LoongArch: KVM: Propagate real error code in kvm_pch_pic_create Tao Cui
2026-10-15 23:46 ` [PATCH v4 3/3] LoongArch: KVM: Reject repeated PCH-PIC CTRL_INIT Tao Cui
2026-10-15 23:56 ` sashiko-bot
2026-10-16 1:03 ` Bibo Mao
2026-10-16 1:31 ` Bibo Mao
2026-10-16 8:01 ` Tao Cui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261015234638.1077815-1-cui.tao@linux.dev \
--to=cui.tao@linux.dev \
--cc=chenhuacai@kernel.org \
--cc=cuitao@kylinos.cn \
--cc=kernel@xen0n.name \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=loongarch@lists.linux.dev \
--cc=maobibo@loongson.cn \
--cc=nagachaithanya9911@gmail.com \
--cc=zhaotianrui@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox