* [kvm-unit-tests PATCH] s390x: stsi: Make output tap13 compatible
@ 2020-05-25 8:43 Janosch Frank
2020-05-25 8:46 ` Thomas Huth
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Janosch Frank @ 2020-05-25 8:43 UTC (permalink / raw)
To: kvm; +Cc: linux-s390, thuth, stzi, mhartmay, david, cohuck
In tap13 output # is a special character and only "skip" and "todo"
are allowed to come after it. Let's appease our CI environment and
replace # with "count".
Signed-off-by: Janosch Frank <frankja@linux.ibm.com>
---
s390x/stsi.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/s390x/stsi.c b/s390x/stsi.c
index 66b4257..b81cea7 100644
--- a/s390x/stsi.c
+++ b/s390x/stsi.c
@@ -129,11 +129,11 @@ static void test_3_2_2(void)
}
report(!memcmp(data->vm[0].uuid, uuid, sizeof(uuid)), "uuid");
- report(data->vm[0].conf_cpus == smp_query_num_cpus(), "cpu # configured");
+ report(data->vm[0].conf_cpus == smp_query_num_cpus(), "cpu count configured");
report(data->vm[0].total_cpus ==
data->vm[0].reserved_cpus + data->vm[0].conf_cpus,
- "cpu # total == conf + reserved");
- report(data->vm[0].standby_cpus == 0, "cpu # standby");
+ "cpu count total == conf + reserved");
+ report(data->vm[0].standby_cpus == 0, "cpu count standby");
report(!memcmp(data->vm[0].name, vm_name, sizeof(data->vm[0].name)),
"VM name == kvm-unit-test");
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [kvm-unit-tests PATCH] s390x: stsi: Make output tap13 compatible
2020-05-25 8:43 [kvm-unit-tests PATCH] s390x: stsi: Make output tap13 compatible Janosch Frank
@ 2020-05-25 8:46 ` Thomas Huth
2020-05-25 8:48 ` David Hildenbrand
2020-05-25 9:43 ` Cornelia Huck
2 siblings, 0 replies; 4+ messages in thread
From: Thomas Huth @ 2020-05-25 8:46 UTC (permalink / raw)
To: Janosch Frank, kvm; +Cc: linux-s390, stzi, mhartmay, david, cohuck
On 25/05/2020 10.43, Janosch Frank wrote:
> In tap13 output # is a special character and only "skip" and "todo"
> are allowed to come after it. Let's appease our CI environment and
> replace # with "count".
>
> Signed-off-by: Janosch Frank <frankja@linux.ibm.com>
> ---
> s390x/stsi.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/s390x/stsi.c b/s390x/stsi.c
> index 66b4257..b81cea7 100644
> --- a/s390x/stsi.c
> +++ b/s390x/stsi.c
> @@ -129,11 +129,11 @@ static void test_3_2_2(void)
> }
>
> report(!memcmp(data->vm[0].uuid, uuid, sizeof(uuid)), "uuid");
> - report(data->vm[0].conf_cpus == smp_query_num_cpus(), "cpu # configured");
> + report(data->vm[0].conf_cpus == smp_query_num_cpus(), "cpu count configured");
> report(data->vm[0].total_cpus ==
> data->vm[0].reserved_cpus + data->vm[0].conf_cpus,
> - "cpu # total == conf + reserved");
> - report(data->vm[0].standby_cpus == 0, "cpu # standby");
> + "cpu count total == conf + reserved");
> + report(data->vm[0].standby_cpus == 0, "cpu count standby");
> report(!memcmp(data->vm[0].name, vm_name, sizeof(data->vm[0].name)),
> "VM name == kvm-unit-test");
Reviewed-by: Thomas Huth <thuth@redhat.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [kvm-unit-tests PATCH] s390x: stsi: Make output tap13 compatible
2020-05-25 8:43 [kvm-unit-tests PATCH] s390x: stsi: Make output tap13 compatible Janosch Frank
2020-05-25 8:46 ` Thomas Huth
@ 2020-05-25 8:48 ` David Hildenbrand
2020-05-25 9:43 ` Cornelia Huck
2 siblings, 0 replies; 4+ messages in thread
From: David Hildenbrand @ 2020-05-25 8:48 UTC (permalink / raw)
To: Janosch Frank, kvm; +Cc: linux-s390, thuth, stzi, mhartmay, cohuck
On 25.05.20 10:43, Janosch Frank wrote:
> In tap13 output # is a special character and only "skip" and "todo"
> are allowed to come after it. Let's appease our CI environment and
> replace # with "count".
>
> Signed-off-by: Janosch Frank <frankja@linux.ibm.com>
> ---
> s390x/stsi.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/s390x/stsi.c b/s390x/stsi.c
> index 66b4257..b81cea7 100644
> --- a/s390x/stsi.c
> +++ b/s390x/stsi.c
> @@ -129,11 +129,11 @@ static void test_3_2_2(void)
> }
>
> report(!memcmp(data->vm[0].uuid, uuid, sizeof(uuid)), "uuid");
> - report(data->vm[0].conf_cpus == smp_query_num_cpus(), "cpu # configured");
> + report(data->vm[0].conf_cpus == smp_query_num_cpus(), "cpu count configured");
> report(data->vm[0].total_cpus ==
> data->vm[0].reserved_cpus + data->vm[0].conf_cpus,
> - "cpu # total == conf + reserved");
> - report(data->vm[0].standby_cpus == 0, "cpu # standby");
> + "cpu count total == conf + reserved");
> + report(data->vm[0].standby_cpus == 0, "cpu count standby");
> report(!memcmp(data->vm[0].name, vm_name, sizeof(data->vm[0].name)),
> "VM name == kvm-unit-test");
>
>
Think you could just have applied a filter on top of the output instead.
Reviewed-by: David Hildenbrand <david@redhat.com>
--
Thanks,
David / dhildenb
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [kvm-unit-tests PATCH] s390x: stsi: Make output tap13 compatible
2020-05-25 8:43 [kvm-unit-tests PATCH] s390x: stsi: Make output tap13 compatible Janosch Frank
2020-05-25 8:46 ` Thomas Huth
2020-05-25 8:48 ` David Hildenbrand
@ 2020-05-25 9:43 ` Cornelia Huck
2 siblings, 0 replies; 4+ messages in thread
From: Cornelia Huck @ 2020-05-25 9:43 UTC (permalink / raw)
To: Janosch Frank; +Cc: kvm, linux-s390, thuth, stzi, mhartmay, david
On Mon, 25 May 2020 10:43:40 +0200
Janosch Frank <frankja@linux.ibm.com> wrote:
> In tap13 output # is a special character and only "skip" and "todo"
> are allowed to come after it. Let's appease our CI environment and
> replace # with "count".
>
> Signed-off-by: Janosch Frank <frankja@linux.ibm.com>
> ---
> s390x/stsi.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-05-25 9:44 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-05-25 8:43 [kvm-unit-tests PATCH] s390x: stsi: Make output tap13 compatible Janosch Frank
2020-05-25 8:46 ` Thomas Huth
2020-05-25 8:48 ` David Hildenbrand
2020-05-25 9:43 ` Cornelia Huck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox