Re: [PATCH v2 3/3] vfio/ccw: Check return code from subchannel quiesce

[Matthew Rosato <mjrosato@linux.ibm.com>]

On 7/28/22 12:05 PM, Eric Farman wrote:
> If a subchannel is busy when a close is performed, the subchannel
> needs to be quiesced and left nice and tidy, so nothing unexpected
> (like a solicited interrupt) shows up while in the closed state.
> Unfortunately, the return code from this call isn't checked,
> so any busy subchannel is treated as a failing one.
> 
> Fix that, so that the close on a busy subchannel happens normally.
> 
> Signed-off-by: Eric Farman <farman@linux.ibm.com>

Reviewed-by: Matthew Rosato <mjrosato@linux.ibm.com>

> ---
>   drivers/s390/cio/vfio_ccw_fsm.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/s390/cio/vfio_ccw_fsm.c b/drivers/s390/cio/vfio_ccw_fsm.c
> index 4b8b623df24f..a59c758869f8 100644
> --- a/drivers/s390/cio/vfio_ccw_fsm.c
> +++ b/drivers/s390/cio/vfio_ccw_fsm.c
> @@ -407,7 +407,7 @@ static void fsm_close(struct vfio_ccw_private *private,
>   
>   	ret = cio_disable_subchannel(sch);
>   	if (ret == -EBUSY)
> -		vfio_ccw_sch_quiesce(sch);
> +		ret = vfio_ccw_sch_quiesce(sch);
>   	if (ret)
>   		goto err_unlock;
>