From: Suravee Suthikulpanit <Suravee.Suthikulpanit@amd.com>
To: "Radim Krčmář" <rkrcmar@redhat.com>
Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
pbonzini@redhat.com, joro@8bytes.org
Subject: Re: [PATCH v2 3/3] KVM: SVM: Add irqchip_split() checks before enabling AVIC
Date: Thu, 14 Sep 2017 08:23:48 -0700 [thread overview]
Message-ID: <3603043c-964f-d10c-8cc0-fa3476e3bbb5@amd.com> (raw)
In-Reply-To: <20170914152031.GA23415@flask>
Radim,
On 9/14/17 08:20, Radim Krčmář wrote:
>> @@ -1594,6 +1593,12 @@ static int avic_init_vcpu(struct vcpu_svm *svm)
>> if (!avic)
>> return 0;
>>
>> + if (!kvm_vcpu_apicv_active(&svm->vcpu)) {
>> + pr_debug("%s: Disable AVIC due to non-split irqchip.\n",
>> + __func__);
> We need to have an extra condition just because of this print ...
> I removed the print altogether when applying -- I thought more about
> that and it was aimed at people who wonder why AVIC was suddenly
> disabled and it's unlikely that they will enable a debug message without
> already knowing the reason,
Make sense. Thanks.
>
> thanks.
>
>> @@ -4388,7 +4393,7 @@ static void svm_set_virtual_x2apic_mode(struct kvm_vcpu *vcpu, bool set)
>>
>> static bool svm_get_enable_apicv(struct kvm_vcpu *vcpu)
>> {
> A close contender was pr_info_once() here:
>
> if (avic && !irqchip_split(vcpu->kvm))
> pr_info_once(...)
>
Looks good.
Thanks,
Suravee
next prev parent reply other threads:[~2017-09-14 15:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-12 15:42 [PATCH v2 0/3] KVM: SVM: Fix guest not booting w/ AVIC enabled Suravee Suthikulpanit
2017-09-12 15:42 ` [PATCH v2 1/3] KVM: SVM: Refactor AVIC vcpu initialization into avic_init_vcpu() Suravee Suthikulpanit
2017-09-12 15:42 ` [PATCH v2 2/3] KVM: Add struct kvm_vcpu pointer parameter to get_enable_apicv() Suravee Suthikulpanit
2017-09-12 15:42 ` [PATCH v2 3/3] KVM: SVM: Add irqchip_split() checks before enabling AVIC Suravee Suthikulpanit
2017-09-14 15:20 ` Radim Krčmář
2017-09-14 15:23 ` Suravee Suthikulpanit [this message]
2017-09-15 19:21 ` Suravee Suthikulpanit
2017-09-15 21:14 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3603043c-964f-d10c-8cc0-fa3476e3bbb5@amd.com \
--to=suravee.suthikulpanit@amd.com \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=rkrcmar@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox