From: Nina Schoetterl-Glausch <nsg@linux.ibm.com>
To: Claudio Imbrenda <imbrenda@linux.ibm.com>, kvm@vger.kernel.org
Cc: frankja@linux.ibm.com, nrb@linux.ibm.com, seiden@linux.ibm.com,
thuth@redhat.com
Subject: Re: [kvm-unit-tests PATCH v1 1/1] s390x: fix make standalone
Date: Tue, 03 Jan 2023 15:05:13 +0100 [thread overview]
Message-ID: <486f8b2f0f1b127a4bcffbbafeff317f4de3872d.camel@linux.ibm.com> (raw)
In-Reply-To: <20221220175508.57180-1-imbrenda@linux.ibm.com>
On Tue, 2022-12-20 at 18:55 +0100, Claudio Imbrenda wrote:
> A recent patch broke make standalone. The function find_word is not
> available when running make standalone, replace it with a simple grep.
>
> Reported-by: Nina Schoetterl-Glausch <nsg@linux.ibm.com>
> Fixes: 743cacf7 ("s390x: don't run migration tests under PV")
> Signed-off-by: Claudio Imbrenda <imbrenda@linux.ibm.com>
Reviewed-by: Nina Schoetterl-Glausch <nsg@linux.ibm.com>
> ---
> scripts/s390x/func.bash | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/s390x/func.bash b/scripts/s390x/func.bash
> index 2a941bbb..6c75e89a 100644
> --- a/scripts/s390x/func.bash
> +++ b/scripts/s390x/func.bash
> @@ -21,7 +21,7 @@ function arch_cmd_s390x()
> "$cmd" "$testname" "$groups" "$smp" "$kernel" "$opts" "$arch" "$check" "$accel" "$timeout"
>
> # run PV test case
> - if [ "$ACCEL" = 'tcg' ] || find_word "migration" "$groups"; then
> + if [ "$ACCEL" = 'tcg' ] || grep -q "migration" <<< "$groups"; then
> return
> fi
> kernel=${kernel%.elf}.pv.bin
prev parent reply other threads:[~2023-01-03 14:05 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-20 17:55 [kvm-unit-tests PATCH v1 1/1] s390x: fix make standalone Claudio Imbrenda
2022-12-21 8:16 ` Nico Boehr
2022-12-21 9:14 ` Nico Boehr
2022-12-26 18:41 ` Andrew Jones
2023-01-03 14:04 ` Nina Schoetterl-Glausch
2023-01-03 14:29 ` Andrew Jones
2023-01-04 11:07 ` Claudio Imbrenda
2023-01-04 12:56 ` Thomas Huth
2023-01-04 14:48 ` Andrew Jones
2022-12-26 18:36 ` Andrew Jones
2023-01-04 12:52 ` Thomas Huth
2023-01-04 14:49 ` Andrew Jones
2023-01-03 14:05 ` Nina Schoetterl-Glausch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=486f8b2f0f1b127a4bcffbbafeff317f4de3872d.camel@linux.ibm.com \
--to=nsg@linux.ibm.com \
--cc=frankja@linux.ibm.com \
--cc=imbrenda@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=nrb@linux.ibm.com \
--cc=seiden@linux.ibm.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox