From: Avi Kivity <avi@redhat.com>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: Marcelo Tosatti <mtosatti@redhat.com>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>
Subject: Re: [PATCH] KVM: VMX: Conditionally reload debug register 6
Date: Tue, 01 Sep 2009 14:53:43 +0300 [thread overview]
Message-ID: <4A9D0B47.20805@redhat.com> (raw)
In-Reply-To: <4A9D08D2.1020407@siemens.com>
On 09/01/2009 02:43 PM, Jan Kiszka wrote:
> @@ -3731,7 +3732,8 @@ static void vmx_vcpu_run(struct kvm_vcpu *vcpu)
>> | (1<< VCPU_EXREG_PDPTR));
>> vcpu->arch.regs_dirty = 0;
>>
>> - get_debugreg(vcpu->arch.dr6, 6);
>> + if (vcpu->arch.switch_db_regs)
>> + get_debugreg(vcpu->arch.dr6, 6);
>>
>> vmx->idt_vectoring_info = vmcs_read32(IDT_VECTORING_INFO_FIELD);
>> if (vmx->rmode.irq.pending)
>>
> That reduces the emulation quality as vcpu->arch.switch_db_regs is only
> set if some breakpoint is active while dr6 has its use also when that is
> not the case).
>
True - there's the TF reason reporting bits.
How about this then:
- if !switch_db_regs, trap #DB
- on #DB trap, copy DR6.BS and DR6.BT to vcpu->arch.dr6, and reinject
the #DB
?
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2009-09-01 11:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-01 11:40 [PATCH] KVM: VMX: Conditionally reload debug register 6 Avi Kivity
2009-09-01 11:43 ` Jan Kiszka
2009-09-01 11:53 ` Avi Kivity [this message]
2009-09-01 12:32 ` Jan Kiszka
2009-09-01 12:54 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A9D0B47.20805@redhat.com \
--to=avi@redhat.com \
--cc=jan.kiszka@siemens.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox