From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Pekka Enberg <penberg@cs.helsinki.fi>,
Ingo Molnar <mingo@elte.hu>, Asias He <asias.hejun@gmail.com>,
Chaitanya Kulkarni <chaitanyakulkarni15@gmail.com>,
Prasad Joshi <prasadjoshi124@
Subject: [PATCH] kvm tools, 9p: Test for tuncation result
Date: Sat, 21 May 2011 16:10:34 +0400 [thread overview]
Message-ID: <4DD7ABBA.6090405@gmail.com> (raw)
Without 'ret' usage I get
| cyrill@sun kvm $ make
| CC virtio/9p.o
| virtio/9p.c: In function ‘virtio_p9_wstat’:
| virtio/9p.c:448:6: error: variable ‘res’ set but not used [-Werror=unused-but-set-variable]
| cc1: all warnings being treated as errors
| make: *** [virtio/9p.o] Error 1
so add a basic check for ftruncate result, this eliminate warning and
we might need to use 'res' status later in caller code.
Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com>
CC: Sasha Levin <levinsasha928@gmail.com>
---
Pekka, are you fine with 'kvm-tools,9p' prefix?
tools/kvm/virtio/9p.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
Index: linux-2.6.git/tools/kvm/virtio/9p.c
===================================================================
--- linux-2.6.git.orig/tools/kvm/virtio/9p.c
+++ linux-2.6.git/tools/kvm/virtio/9p.c
@@ -445,7 +445,7 @@ static bool virtio_p9_wstat(struct p9_ms
struct p9_twstat *twstat = (struct p9_twstat *)msg->msg;
struct p9_str *str;
struct p9_fid *fid = &p9dev.fids[twstat->fid];
- int res;
+ int res = 0;
if (twstat->stat.length != -1UL)
res = ftruncate(fid->fd, twstat->stat.length);
@@ -472,7 +472,8 @@ static bool virtio_p9_wstat(struct p9_ms
*outlen = VIRTIO_P9_HDR_LEN;
set_p9msg_hdr(outmsg, *outlen, P9_RWSTAT, msg->tag);
- return true;
+
+ return res == 0;
}
static bool virtio_p9_remove(struct p9_msg *msg, u32 len, struct iovec *iov, u32 *outlen)
next reply other threads:[~2011-05-21 12:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-21 12:10 Cyrill Gorcunov [this message]
2011-05-21 13:35 ` [PATCH] kvm tools, 9p: Test for tuncation result Pekka Enberg
2011-05-21 14:03 ` Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DD7ABBA.6090405@gmail.com \
--to=gorcunov@gmail.com \
--cc=asias.hejun@gmail.com \
--cc=chaitanyakulkarni15@gmail.com \
--cc=mingo@elte.hu \
--cc=penberg@cs.helsinki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox