From: Sasha Levin <levinsasha928@gmail.com>
To: Pekka Enberg <penberg@kernel.org>
Cc: Cyrill Gorcunov <gorcunov@gmail.com>,
Pekka Enberg <penberg@cs.helsinki.fi>,
Ingo Molnar <mingo@elte.hu>, Asias He <asias.hejun@gmail.com>,
Chaitanya Kulkarni <chaitanyakulkarni15@gmail.com>,
Prasad Joshi <prasadjoshi124@gmail.com>,
Thomas Heil <heil@terminal-consulting.de>,
kvm-vger <kvm@vger.kernel.org>
Subject: Re: [PATCH] kvm tools, 9p: Test for tuncation result
Date: Sat, 21 May 2011 17:03:12 +0300 [thread overview]
Message-ID: <1305986592.27595.0.camel@lappy> (raw)
In-Reply-To: <BANLkTimR-CsW-tqMqM8odJVnAsnZz3689A@mail.gmail.com>
On Sat, 2011-05-21 at 16:35 +0300, Pekka Enberg wrote:
> On Sat, May 21, 2011 at 3:10 PM, Cyrill Gorcunov <gorcunov@gmail.com> wrote:
> > Without 'ret' usage I get
> >
> > | cyrill@sun kvm $ make
> > | CC virtio/9p.o
> > | virtio/9p.c: In function ‘virtio_p9_wstat’:
> > | virtio/9p.c:448:6: error: variable ‘res’ set but not used [-Werror=unused-but-set-variable]
> > | cc1: all warnings being treated as errors
> > | make: *** [virtio/9p.o] Error 1
> >
> > so add a basic check for ftruncate result, this eliminate warning and
> > we might need to use 'res' status later in caller code.
> >
> > Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com>
> > CC: Sasha Levin <levinsasha928@gmail.com>
>
> Sasha?
Looks good to me.
Acked-by: Sasha Levin <levinsasha928@gmail.com>
> > ---
> >
> > Pekka, are you fine with 'kvm-tools,9p' prefix?
>
> Sure.
--
Sasha.
prev parent reply other threads:[~2011-05-21 14:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-21 12:10 [PATCH] kvm tools, 9p: Test for tuncation result Cyrill Gorcunov
2011-05-21 13:35 ` Pekka Enberg
2011-05-21 14:03 ` Sasha Levin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1305986592.27595.0.camel@lappy \
--to=levinsasha928@gmail.com \
--cc=asias.hejun@gmail.com \
--cc=chaitanyakulkarni15@gmail.com \
--cc=gorcunov@gmail.com \
--cc=heil@terminal-consulting.de \
--cc=kvm@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=penberg@cs.helsinki.fi \
--cc=penberg@kernel.org \
--cc=prasadjoshi124@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox