From: Feng Yang <fyang@redhat.com>
To: Lucas Meneghel Rodrigues <lmr@redhat.com>
Cc: autotest@test.kernel.org, kvm@vger.kernel.org
Subject: Re: [PATCH] KVM Test: Switch current working folder in unattended_install.py.
Date: Mon, 23 May 2011 10:25:46 +0800 [thread overview]
Message-ID: <4DD9C5AA.8070305@redhat.com> (raw)
In-Reply-To: <1305917946.15658.12.camel@freedom>
On 05/21/2011 02:59 AM, Lucas Meneghel Rodrigues wrote:
> On Thu, 2011-05-19 at 18:24 +0800, fyang@redhat.com wrote:
>> From: Feng Yang<fyang@redhat.com>
>>
>> Current working folder for
>> unattended_install_config = UnattendedInstallConfig(test, params)
>> unattended_install_config.setup()
>> must be kvm folder.
> This is not needed at all. What might be going on your setup is some
> incorrectly set or absent path that might be messing up with relative
> paths during your install.
>
> Please provide some more info so we can fix your problem properly.
> Meanwhile I'm marking this as 'rejected'.
>
> Thanks!
Thanks for your comment.
After merge upstream code to our local tree, I found that our local
unattended_install could not work.
Before, Current working folder for unattended.py is kvm folder,
changed in process_command.
Now Current working folder for
unattended_install_config = UnattendedInstallConfig(test, params)
unattended_install_config.setup()
changed to case result folder. So our unattended_install always fails at
could not find ks.iso.
Then I send this patch.
I will recheck our local code and configure.
Thanks very much!
Feng Yang
>> Signed-off-by: Feng Yang<fyang@redhat.com>
>> ---
>> client/tests/kvm/tests/unattended_install.py | 3 +++
>> 1 files changed, 3 insertions(+), 0 deletions(-)
>>
>> diff --git a/client/tests/kvm/tests/unattended_install.py b/client/tests/kvm/tests/unattended_install.py
>> index 50a8c7a..eee1761 100644
>> --- a/client/tests/kvm/tests/unattended_install.py
>> +++ b/client/tests/kvm/tests/unattended_install.py
>> @@ -506,8 +506,11 @@ def run_unattended_install(test, params, env):
>> @param params: Dictionary with the test parameters.
>> @param env: Dictionary with test environment.
>> """
>> + cur_folder = os.getcwd()
>> + os.chdir(test.bindir)
>> unattended_install_config = UnattendedInstallConfig(test, params)
>> unattended_install_config.setup()
>> + os.chdir(cur_folder)
>> vm = env.get_vm(params["main_vm"])
>> vm.create()
>>
>
> --
> To unsubscribe from this list: send the line "unsubscribe kvm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2011-05-23 2:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-19 10:24 [PATCH] KVM Test: Switch current working folder in unattended_install.py fyang
2011-05-20 18:59 ` [Autotest] " Lucas Meneghel Rodrigues
2011-05-23 2:25 ` Feng Yang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DD9C5AA.8070305@redhat.com \
--to=fyang@redhat.com \
--cc=autotest@test.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=lmr@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox