From: Orit Wasserman <owasserm@redhat.com>
To: Marcelo Tosatti <mtosatti@redhat.com>
Cc: Dongxiao Xu <dongxiao.xu@intel.com>,
kvm@vger.kernel.org, gleb@redhat.com
Subject: Re: [PATCH v2 4/4] nested vmx: use a list to store the launched vmcs12 for L1 VMM
Date: Wed, 28 Nov 2012 14:30:17 +0200 [thread overview]
Message-ID: <50B603D9.10702@redhat.com> (raw)
In-Reply-To: <20121128002908.GD8295@amt.cnet>
On 11/28/2012 02:29 AM, Marcelo Tosatti wrote:
> On Thu, Nov 22, 2012 at 12:51:59PM +0800, Dongxiao Xu wrote:
>> The launch state is not a member in the VMCS area, use a separate
>> variable (list) to store it instead.
>>
>> Signed-off-by: Dongxiao Xu <dongxiao.xu@intel.com>
>
> 1. What is the problem with keeping launched state in the VMCS?
> Assuming there is a positive answer to the above:
>
> 2. Don't you have to change VMCS ID?
>
> 3. Can't it be kept somewhere else other than a list? Current scheme
> allows guest to allocate unlimited amounts of host memory.
I agree with Marcelo you have to limit the number of VMCS in the list otherwise
it will be easy to attack a host with nested :)
>
> 4. What is the state of migration / nested vmx again? If vmcs12 is
> migrated, this means launched state is not migrated anymore.
>
> Patches 1-3 seem fine.
>
> --
> To unsubscribe from this list: send the line "unsubscribe kvm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2012-11-28 12:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-22 4:51 [PATCH v2 0/4] nested vmx code clean up and restructure Dongxiao Xu
2012-11-22 4:51 ` [PATCH v2 1/4] nested vmx: clean up for vmcs12 read and write Dongxiao Xu
2012-11-22 4:51 ` [PATCH v2 2/4] nested vmx: clean up for nested_cpu_has_xxx functions Dongxiao Xu
2012-11-22 4:51 ` [PATCH v2 3/4] nested vmx: use vmcs12_read/write() to operate VMCS fields Dongxiao Xu
2012-11-22 4:51 ` [PATCH v2 4/4] nested vmx: use a list to store the launched vmcs12 for L1 VMM Dongxiao Xu
2012-11-28 0:29 ` Marcelo Tosatti
2012-11-28 11:27 ` Gleb Natapov
2012-11-29 2:05 ` Xu, Dongxiao
2012-11-28 12:30 ` Orit Wasserman [this message]
2012-11-29 2:09 ` Xu, Dongxiao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50B603D9.10702@redhat.com \
--to=owasserm@redhat.com \
--cc=dongxiao.xu@intel.com \
--cc=gleb@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox