Re: [PATCH uq/master] kvm_stat: add option to display non tracepoint based stats

[Paolo Bonzini <pbonzini@redhat.com>]

Il 20/05/2014 20:38, Marcelo Tosatti ha scritto:
>
> The old stats contain information not available in the tracepoints.
>
> Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>
>
> diff --git a/scripts/kvm/kvm_stat b/scripts/kvm/kvm_stat
> index 762544b..6ac3b21 100755
> --- a/scripts/kvm/kvm_stat
> +++ b/scripts/kvm/kvm_stat
> @@ -493,12 +493,21 @@ options.add_option('-f', '--fields',
>                     dest = 'fields',
>                     help = 'fields to display (regex)',
>                     )
> +options.add_option('-o', '--old',
> +                   action = 'store_true',
> +                   default = False,
> +                   dest = 'old',
> +                   help = 'show kvm statistics counters (not tracepoint based)',
> +                   )
>  (options, args) = options.parse_args(sys.argv)
>
> -try:
> -    provider = TracepointProvider()
> -except:
> +if options.old:
>      provider = DebugfsProvider()
> +else:
> +    try:
> +        provider = TracepointProvider()
> +    except:
> +        provider = DebugfsProvider()
>
>  stats = Stats(provider, fields = options.fields)
>
>

Let's instead show information from both providers.  I am sending a patch.

Paolo