From: "Nikunj A. Dadhania" <nikunj@amd.com>
To: Sean Christopherson <seanjc@google.com>
Cc: pbonzini@redhat.com, kvm@vger.kernel.org,
thomas.lendacky@amd.com, santosh.shukla@amd.com, bp@alien8.de,
isaku.yamahata@intel.com, vaishali.thakkar@suse.com
Subject: Re: [PATCH v6 3/4] KVM: SVM: Add GUEST_TSC_FREQ MSR for Secure TSC enabled guests
Date: Thu, 26 Jun 2025 11:37:55 +0530 [thread overview]
Message-ID: <54abb703-977e-46c8-80d9-d5c5b95aba64@amd.com> (raw)
In-Reply-To: <aFwECPca4SbV916d@google.com>
On 6/25/2025 7:43 PM, Sean Christopherson wrote:
> On Tue, Apr 08, 2025, Nikunj A Dadhania wrote:
>> @@ -377,10 +377,19 @@ static __always_inline bool sev_snp_guest(struct kvm *kvm)
>> return (sev->vmsa_features & SVM_SEV_FEAT_SNP_ACTIVE) &&
>> !WARN_ON_ONCE(!sev_es_guest(kvm));
>> }
>> +
>> +static inline bool snp_secure_tsc_enabled(struct kvm *kvm)
>
> This is only ever used in sev.c, it has no business living in svm.c. And there's
> especially no reason to have a stub for CONFIG_KVM_AMD_SEV=n.
Ack, will move this to sev.c and remove the stub as well.
Regards
Nikunj
next prev parent reply other threads:[~2025-06-26 6:08 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-08 9:32 [PATCH v6 0/4] Enable Secure TSC for SEV-SNP Nikunj A Dadhania
2025-04-08 9:32 ` [PATCH v6 1/4] x86/cpufeatures: Add SNP Secure TSC Nikunj A Dadhania
2025-04-08 9:32 ` [PATCH v6 2/4] KVM: SVM: Add missing member in SNP_LAUNCH_START command structure Nikunj A Dadhania
2025-04-08 9:32 ` [PATCH v6 3/4] KVM: SVM: Add GUEST_TSC_FREQ MSR for Secure TSC enabled guests Nikunj A Dadhania
2025-06-25 14:13 ` Sean Christopherson
2025-06-26 6:07 ` Nikunj A. Dadhania [this message]
2025-04-08 9:32 ` [PATCH v6 4/4] KVM: SVM: Enable Secure TSC for SNP guests Nikunj A Dadhania
2025-06-25 14:27 ` Sean Christopherson
2025-06-26 8:53 ` Nikunj A. Dadhania
2025-04-14 5:50 ` [PATCH v6 0/4] Enable Secure TSC for SEV-SNP Nikunj A Dadhania
2025-05-05 4:50 ` Nikunj A. Dadhania
2025-06-09 8:51 ` Nikunj A. Dadhania
2025-06-25 22:25 ` Sean Christopherson
2025-06-26 6:10 ` Nikunj A. Dadhania
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54abb703-977e-46c8-80d9-d5c5b95aba64@amd.com \
--to=nikunj@amd.com \
--cc=bp@alien8.de \
--cc=isaku.yamahata@intel.com \
--cc=kvm@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=santosh.shukla@amd.com \
--cc=seanjc@google.com \
--cc=thomas.lendacky@amd.com \
--cc=vaishali.thakkar@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox