From: Paolo Bonzini <pbonzini@redhat.com>
To: Andrew Jones <drjones@redhat.com>,
Alexander Gordeev <agordeev@redhat.com>
Cc: kvm@vger.kernel.org, "Thomas Huth" <thuth@redhat.com>,
"Radim Krčmář" <rkrcmar@redhat.com>
Subject: Re: [kvm-unit-tests PATCH v10 12/12] ppc64: Introduce lib/ppc64/asm/barrier.h
Date: Mon, 13 Jun 2016 15:34:53 +0200 [thread overview]
Message-ID: <568ceb38-ba54-b855-ee79-166327a7c8f1@redhat.com> (raw)
In-Reply-To: <20160613104925.ndn7bwccbwvnpqbd@hawk.localdomain>
On 13/06/2016 12:49, Andrew Jones wrote:
>> +
>> +#ifndef mb
>> +#define mb() asm volatile("":::"memory")
>> +#endif
>> +#ifndef rmb
>> +#define rmb() asm volatile("":::"memory")
>> +#endif
>> +#ifndef wmb
>> +#define wmb() asm volatile("":::"memory")
>> +#endif
This is certainly wrong for PPC64.
Paolo
next prev parent reply other threads:[~2016-06-13 13:35 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-06 10:25 [kvm-unit-tests PATCH v8 00/12] Cleanup low-level arch code Alexander Gordeev
2016-06-06 10:25 ` [kvm-unit-tests PATCH v8 01/12] Remove unused and unnecessary PHYS32 macro Alexander Gordeev
2016-06-06 10:25 ` [kvm-unit-tests PATCH v8 02/12] Move phys_addr_t type definition to lib/libcflat.h Alexander Gordeev
2016-06-06 10:25 ` [kvm-unit-tests PATCH v8 03/12] x86: Introduce lib/x86/asm/page.h Alexander Gordeev
2016-06-06 10:25 ` [kvm-unit-tests PATCH v8 04/12] x86: Introduce lib/x86/asm/io.h Alexander Gordeev
2016-06-06 10:25 ` [kvm-unit-tests PATCH v8 05/12] x86: Introduce lib/x86/asm/barrier.h Alexander Gordeev
2016-06-06 10:25 ` [kvm-unit-tests PATCH v8 06/12] io: Separate overrides of virt_to_phys() and phys_to_virt() Alexander Gordeev
2016-06-06 10:25 ` [kvm-unit-tests PATCH v8 07/12] io: Disallow memory re-ordering for generic memory barriers Alexander Gordeev
2016-06-06 10:25 ` [kvm-unit-tests PATCH v8 08/12] x86: Cleanup PAGE_* constants Alexander Gordeev
2016-06-06 15:21 ` Paolo Bonzini
2016-06-08 7:59 ` Alexander Gordeev
2016-06-08 7:58 ` Paolo Bonzini
2016-06-08 10:07 ` Andrew Jones
2016-06-08 10:19 ` Paolo Bonzini
2016-06-06 10:25 ` [kvm-unit-tests PATCH v8 09/12] x86: Cleanup PT_*_MASK flags Alexander Gordeev
2016-06-06 10:25 ` [kvm-unit-tests PATCH v8 10/12] io: Make ioremap() prototype conform to Linux one Alexander Gordeev
2016-06-06 10:25 ` [kvm-unit-tests PATCH v8 11/12] x86: io: Factor out ioremap() Alexander Gordeev
2016-06-06 10:25 ` [kvm-unit-tests PATCH v8 12/12] io: Unify IO accessors across architectures Alexander Gordeev
2016-06-06 12:22 ` Andrew Jones
2016-06-10 6:36 ` [kvm-unit-tests PATCH v9 12/12] ppc64: Introduce lib/ppc64/asm/barrier.h Alexander Gordeev
2016-06-10 7:01 ` Andrew Jones
2016-06-10 7:08 ` Andrew Jones
2016-06-10 8:17 ` [kvm-unit-tests PATCH v10 " Alexander Gordeev
2016-06-13 10:49 ` Andrew Jones
2016-06-13 13:34 ` Paolo Bonzini [this message]
2016-06-13 14:04 ` Andrew Jones
2016-06-13 14:16 ` Paolo Bonzini
2016-07-11 14:52 ` Paolo Bonzini
2016-06-10 6:37 ` [kvm-unit-tests PATCH v9 13/12] io: Unify IO accessors across architectures Alexander Gordeev
2016-06-10 7:07 ` Andrew Jones
2016-06-10 8:13 ` Alexander Gordeev
2016-06-10 8:17 ` [kvm-unit-tests PATCH v10 " Alexander Gordeev
2016-06-13 10:51 ` Andrew Jones
2016-06-13 13:35 ` [kvm-unit-tests PATCH v9 " Paolo Bonzini
2016-06-13 13:57 ` Andrew Jones
2016-06-13 14:03 ` Paolo Bonzini
2016-06-13 14:17 ` Andrew Jones
2016-06-29 8:24 ` Alexander Gordeev
2016-07-09 20:39 ` Alexander Gordeev
2016-07-11 15:01 ` Paolo Bonzini
2016-07-11 16:17 ` Alexander Gordeev
2016-07-11 16:15 ` Paolo Bonzini
2016-07-12 8:27 ` Andrew Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=568ceb38-ba54-b855-ee79-166327a7c8f1@redhat.com \
--to=pbonzini@redhat.com \
--cc=agordeev@redhat.com \
--cc=drjones@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=rkrcmar@redhat.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox