From: Thomas Huth <thuth@redhat.com>
To: Andrew Jones <drjones@redhat.com>, kvm@vger.kernel.org
Cc: lvivier@redhat.com, richard.weiyang@gmail.com
Subject: Re: [kvm-unit-tests PATCH 2/2] powerpc/ppc64: Makefile cleanup
Date: Tue, 10 May 2016 08:19:36 +0200 [thread overview]
Message-ID: <57317D78.6080809@redhat.com> (raw)
In-Reply-To: <1462802466-22634-3-git-send-email-drjones@redhat.com>
On 09.05.2016 16:01, Andrew Jones wrote:
> This does the same cleanup as 'x86: Makefile refine'
>
> Signed-off-by: Andrew Jones <drjones@redhat.com>
> ---
> powerpc/Makefile.common | 13 ++++---------
> 1 file changed, 4 insertions(+), 9 deletions(-)
>
> diff --git a/powerpc/Makefile.common b/powerpc/Makefile.common
> index 4449aec616853..60d545c98e38c 100644
> --- a/powerpc/Makefile.common
> +++ b/powerpc/Makefile.common
> @@ -22,6 +22,9 @@ CFLAGS += -I lib -I lib/libfdt
> CFLAGS += -Wa,-mregnames
> CFLAGS += -fpie
>
> +# We want to keep intermediate files: %.elf and %.o
> +.PRECIOUS: %.elf %.o
If you just want to keep intermediate files, wouldn't it be better to
use .SECONDARY instead of .PRECIOUS? .PRECIOUS seems to contain some
more magic that comes into action when make is killed by a signal... not
sure if we want to have that here?
Thomas
next prev parent reply other threads:[~2016-05-10 6:19 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-09 14:01 [kvm-unit-tests PATCH 0/2] arm/powerpc: Makefile cleanup Andrew Jones
2016-05-09 14:01 ` [kvm-unit-tests PATCH 1/2] arm/arm64: " Andrew Jones
2016-05-09 22:24 ` Wei Yang
2016-05-09 14:01 ` [kvm-unit-tests PATCH 2/2] powerpc/ppc64: " Andrew Jones
2016-05-09 22:24 ` Wei Yang
2016-05-10 6:19 ` Thomas Huth [this message]
2016-05-10 6:35 ` Andrew Jones
2016-05-10 7:44 ` Laurent Vivier
2016-05-10 8:42 ` Thomas Huth
2016-05-10 8:55 ` Laurent Vivier
2016-05-10 9:29 ` Thomas Huth
2016-05-10 9:21 ` Andrew Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57317D78.6080809@redhat.com \
--to=thuth@redhat.com \
--cc=drjones@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=lvivier@redhat.com \
--cc=richard.weiyang@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox