From: Thomas Huth <thuth@redhat.com>
To: Laurent Vivier <lvivier@redhat.com>, Andrew Jones <drjones@redhat.com>
Cc: kvm@vger.kernel.org, richard.weiyang@gmail.com
Subject: Re: [kvm-unit-tests PATCH 2/2] powerpc/ppc64: Makefile cleanup
Date: Tue, 10 May 2016 11:29:57 +0200 [thread overview]
Message-ID: <5731AA15.6060208@redhat.com> (raw)
In-Reply-To: <25ad0aff-5bf3-2e2c-bb4f-61c7a99d399c@redhat.com>
On 10.05.2016 10:55, Laurent Vivier wrote:
>
>
> On 10/05/2016 10:42, Thomas Huth wrote:
>> On 10.05.2016 09:44, Laurent Vivier wrote:
>>>
> ...
>>> I don't understand why you want to keep intermediate files. If they have
>>> to be kept, they should be primary targets.
>>>
>>> It seems for, at least ppc64, we don't need the .PRECIOUS.
>>
>> They could be useful for debugging purposes, e.g. for running "objdump"
>> on them... ?
>
> You can run objdump on the .elf.
That should work most of the time ... but sometimes it's more convenient
to look at the code in the .o files only, so that you do not have to
struggle with the disassembly code of all other parts as well.
Anyway, I just tried the patch with the .PRECIOUS line disabled, and I
got a very strange behavior: The first time when I run make after a
"make clean", it deletes all *.o files in the powerpc folder. But when I
run "make" again the second time, the *.o files are not deleted anymore!
That's very confusing ... not sure if we want to have that behavior, so
maybe let's better keep that .PRECIOUS line?
Thomas
next prev parent reply other threads:[~2016-05-10 9:30 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-09 14:01 [kvm-unit-tests PATCH 0/2] arm/powerpc: Makefile cleanup Andrew Jones
2016-05-09 14:01 ` [kvm-unit-tests PATCH 1/2] arm/arm64: " Andrew Jones
2016-05-09 22:24 ` Wei Yang
2016-05-09 14:01 ` [kvm-unit-tests PATCH 2/2] powerpc/ppc64: " Andrew Jones
2016-05-09 22:24 ` Wei Yang
2016-05-10 6:19 ` Thomas Huth
2016-05-10 6:35 ` Andrew Jones
2016-05-10 7:44 ` Laurent Vivier
2016-05-10 8:42 ` Thomas Huth
2016-05-10 8:55 ` Laurent Vivier
2016-05-10 9:29 ` Thomas Huth [this message]
2016-05-10 9:21 ` Andrew Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5731AA15.6060208@redhat.com \
--to=thuth@redhat.com \
--cc=drjones@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=lvivier@redhat.com \
--cc=richard.weiyang@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox