From: Paolo Bonzini <pbonzini@redhat.com>
To: Jim Mattson <jmattson@google.com>
Cc: kvm@vger.kernel.org, zxwang42@gmail.com, marcorr@google.com,
seanjc@google.com, jroedel@suse.de, varad.gautam@suse.com
Subject: Re: [PATCH v2 kvm-unit-tests 2/2] replace tss_descr global with a function
Date: Thu, 21 Oct 2021 09:17:47 +0200 [thread overview]
Message-ID: <62e5dd2a-929d-935d-829b-e2726d0d4f72@redhat.com> (raw)
In-Reply-To: <CALMp9eTjE1zbrun-bMSZTTodo1AnUpPvfhYgMoTkbfdAQz7mZg@mail.gmail.com>
On 21/10/21 00:01, Jim Mattson wrote:
> On Wed, Oct 20, 2021 at 2:31 PM Paolo Bonzini <pbonzini@redhat.com> wrote:
>>
>> On 20/10/21 23:18, Jim Mattson wrote:
>>>>>> - vmcs_write(GUEST_LIMIT_TR, tss_descr.limit);
>>>>>> + vmcs_write(GUEST_LIMIT_TR, 0x67);
>>>>> Isn't the limit still set to 0xFFFF in {cstart,cstart64}.S? And
>>>>> doesn't the VMware backdoor test assume there's room for an I/O
>>>>> permission bitmap?
>>>>>
>>>> Yes, but this is just for L2. The host TR limit is restored to 0x67 on
>>>> every vmexit, and it seemed weird to run L1 and L2 with different limits.
>>> Perhaps you could change the limits in the GDT entries to match?
>>
>> So keep it 0x67 and adjust it to the size of the IOPM in the VMware
>> backdoor test?
>
> Right. That would seem to achieve the greatest consistency.
>
Let's just add a get_gdt_entry_limit that takes into account the G bit too.
Paolo
next prev parent reply other threads:[~2021-10-21 7:17 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-20 19:27 [PATCH v2 kvm-unit-tests 0/2] remove tss_descr, replace with a function Paolo Bonzini
2021-10-20 19:27 ` [PATCH v2 kvm-unit-tests 1/2] unify field names and definitions for GDT descriptors Paolo Bonzini
2021-10-21 0:07 ` Marc Orr
2021-10-20 19:27 ` [PATCH v2 kvm-unit-tests 2/2] replace tss_descr global with a function Paolo Bonzini
2021-10-20 20:06 ` Sean Christopherson
2021-10-20 20:46 ` Jim Mattson
2021-10-20 21:12 ` Paolo Bonzini
2021-10-20 21:18 ` Jim Mattson
2021-10-20 21:31 ` Paolo Bonzini
2021-10-20 22:01 ` Jim Mattson
2021-10-21 7:17 ` Paolo Bonzini [this message]
2021-10-21 3:50 ` Marc Orr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=62e5dd2a-929d-935d-829b-e2726d0d4f72@redhat.com \
--to=pbonzini@redhat.com \
--cc=jmattson@google.com \
--cc=jroedel@suse.de \
--cc=kvm@vger.kernel.org \
--cc=marcorr@google.com \
--cc=seanjc@google.com \
--cc=varad.gautam@suse.com \
--cc=zxwang42@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox