From: Sean Christopherson <seanjc@google.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: kvm@vger.kernel.org, jmattson@google.com, zxwang42@gmail.com,
marcorr@google.com, jroedel@suse.de, varad.gautam@suse.com
Subject: Re: [PATCH v2 kvm-unit-tests 2/2] replace tss_descr global with a function
Date: Wed, 20 Oct 2021 20:06:10 +0000 [thread overview]
Message-ID: <YXB2spOaSQhaF0Vb@google.com> (raw)
In-Reply-To: <20211020192732.960782-3-pbonzini@redhat.com>
On Wed, Oct 20, 2021, Paolo Bonzini wrote:
> +typedef struct {
> + gdt_entry_t common;
> uint32_t base4;
> uint32_t zero;
> -} __attribute__((__packed__));
> +} __attribute__((__packed__)) gdt_entry16_t;
I doubt I am the only one that is going to misread this as "GDT entry in 16-bit
mode" without thinking critically about what "16" might mean.
Why not this, or some variant thereof? The gdt64 part is a bit gross, but I
don't think it's likely to be misinterpreted.
gdt64_system_entry_t;
next prev parent reply other threads:[~2021-10-20 20:06 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-20 19:27 [PATCH v2 kvm-unit-tests 0/2] remove tss_descr, replace with a function Paolo Bonzini
2021-10-20 19:27 ` [PATCH v2 kvm-unit-tests 1/2] unify field names and definitions for GDT descriptors Paolo Bonzini
2021-10-21 0:07 ` Marc Orr
2021-10-20 19:27 ` [PATCH v2 kvm-unit-tests 2/2] replace tss_descr global with a function Paolo Bonzini
2021-10-20 20:06 ` Sean Christopherson [this message]
2021-10-20 20:46 ` Jim Mattson
2021-10-20 21:12 ` Paolo Bonzini
2021-10-20 21:18 ` Jim Mattson
2021-10-20 21:31 ` Paolo Bonzini
2021-10-20 22:01 ` Jim Mattson
2021-10-21 7:17 ` Paolo Bonzini
2021-10-21 3:50 ` Marc Orr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YXB2spOaSQhaF0Vb@google.com \
--to=seanjc@google.com \
--cc=jmattson@google.com \
--cc=jroedel@suse.de \
--cc=kvm@vger.kernel.org \
--cc=marcorr@google.com \
--cc=pbonzini@redhat.com \
--cc=varad.gautam@suse.com \
--cc=zxwang42@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox