Re: [kvm-unit-tests PATCH] Compile code with "-Wwrite-strings"

[Paolo Bonzini <pbonzini@redhat.com>]

On 28/06/2017 22:10, Thomas Huth wrote:
> On 28.06.2017 19:27, David Hildenbrand wrote:
>> On 28.06.2017 14:04, Thomas Huth wrote:
>>> So we make sure that we do not accidentially write to constant
>>
>> "accidentally" (I wouldn't know if Thunderbird wouldn't tell me ;) )
> 
> Oh, ok. Paolo, Radim, could you please fix it when picking up the patch?

Sure.

>> I assume this option has been around for quite some while, so no
>> reasonable gcc will spit fire.
> 
> A very quick search revealed that it is at least 14 years old and GCC
> 4.4 already contained it. Likely even earlier versions. I think we do
> not really support older versions anymore, so that should be ok.

Yes, I think I've used it in GCC 2.x or so. :)

Paolo

>> Reviewed-by: David Hildenbrand <david@redhat.com>
> 
> Thanks!
> 
>  Thomas
>