Re: [Bochs-developers] [PATCH][BIOS] Fill IPL tableaccordingdiscovered ATA drives

["Sebastian Herbszt" <herbszt@gmx.de>]

Laurent Vivier wrote:
> Le dimanche 07 décembre 2008 à 19:11 +0100, Sebastian Herbszt a écrit :
>> Laurent Vivier wrote:
>> > This patch shows in boot menu only available devices.
>> >
>> > This patch has been tested with Bochs BIOS version from the KVM source tree.
>> >
>> > Signed-off-by: Laurent Vivier <Laurent.Vivier@bull.net>
>> > ---
>> > bios/rombios.c |   54 +++++++++++++++++++++++++++++++++++++-----------------
>> > 1 files changed, 37 insertions(+), 17 deletions(-)
>> >
>> > diff --git a/bios/rombios.c b/bios/rombios.c
>> > index 70b3584..d2a7c09 100644
>> > --- a/bios/rombios.c
>> > +++ b/bios/rombios.c
>> > @@ -1981,18 +1981,6 @@ init_boot_vectors()
>> >   memcpyb(IPL_SEG, IPL_TABLE_OFFSET + count * sizeof (e), ss, &e, sizeof (e));
>> >   count++;
>> >
>> > -  /* First HDD */
>> > -  e.type = IPL_TYPE_HARDDISK; e.flags = 0; e.vector = 0; e.description = 0; e.reserved = 0;
>> > -  memcpyb(IPL_SEG, IPL_TABLE_OFFSET + count * sizeof (e), ss, &e, sizeof (e));
>> > -  count++;
>>
>> We need this bit for the !BX_USE_ATADRV case. Please "#if !BX_USE_ATADRV ... #endif" it
>> instead of removing.
>
> If there is no ATA drive, what is the aim of adding an harddrive in the IPL table ?

I think BX_USE_ATADRV enables the "new" ATA/ATAPI driver. You can still use hard drives with
the older code enabled by BX_USE_ATADRV=0.

- Sebastian