Re: [PATCH v3 25/28] KVM: arm64: Engage NV3 TLBI trap elision

[Marc Zyngier <maz@kernel.org>]

On Wed, 22 Jul 2026 09:57:45 +0100,
sashiko-bot@kernel.org wrote:
> 
> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [Low] Stray double semicolon creates an empty statement.
> --
> 
> --- Patch [25]: [PATCH v3 25/28] KVM: arm64: Engage NV3 TLBI trap elision ---
> commit dabbb189ece66c0128f9610303e005d9bdd94252
> Author: Marc Zyngier <maz@kernel.org>
> 
> KVM: arm64: Engage NV3 TLBI trap elision
> 
> This commit enables NV3 TLBI trap elision for guests that are not NV2 aware,
> relaxing the TLBI traps when only the guest's S1 translation is affected.
> 
> > diff --git a/arch/arm64/include/asm/kvm_emulate.h b/arch/arm64/include/asm/kvm_emulate.h
> > --- a/arch/arm64/include/asm/kvm_emulate.h
> > +++ b/arch/arm64/include/asm/kvm_emulate.h
> [ ... ]
> > @@ -715,6 +715,19 @@ static inline void vcpu_set_hcrx(struct kvm_vcpu *vcpu)
> [ ... ]
> > +			if (!kvm_has_nv2(vcpu->kvm)) {
> > +				vcpu->arch.hcrx_el2 |= (HCRX_EL2_NVnTTLB   |
> > +							HCRX_EL2_NVnTTLBIS);
> > +
> > +				if (kvm_has_feat(kvm, ID_AA64ISAR0_EL1, TLB, OS))
> > +					vcpu->arch.hcrx_el2 |= HCRX_EL2_NVnTTLBOS;;
> 
> [Severity: Low]
> This isn't a bug, but there's a stray double semicolon at the end of this
> statement.

I'll fix that.

Thanks,

	M.

-- 
Without deviation from the norm, progress is not possible.