From: Marc Zyngier <maz@kernel.org>
To: Haseeb Ashraf <haseebashraf091@gmail.com>
Cc: Peter Maydell <peter.maydell@linaro.org>,
qemu-arm@nongnu.org,
Pierrick Bouvier <pierrick.bouvier@oss.qualcomm.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Volodymyr Babchuk <volodymyr.babchuk@epam.com>,
Haseeb Ashraf <haseeb.ashraf@siemens.com>,
qemu-devel@nongnu.org, kvm@vger.kernel.org,
Eric Auger <eauger@redhat.com>
Subject: Re: [PATCH 0/1] hw/arm/virt: add vhe option for nested virtualization
Date: Sat, 21 Nov 2026 13:52:27 +0000 [thread overview]
Message-ID: <86qzgez3z8.wl-maz@kernel.org> (raw)
In-Reply-To: <20261121095636.289814-1-haseebashraf091@gmail.com>
On Sat, 21 Nov 2026 09:56:35 +0000,
Haseeb Ashraf <haseebashraf091@gmail.com> wrote:
>
> Hi,
>
> The virt board currently enables VHE whenever virtualization=on. There
> is no way to expose EL2 in nVHE mode to a type-1 guest hypervisor.
>
> This series adds a vhe machine property, enabled by default for
> compatibility. Setting vhe=off propagates the requested mode to the
> guest CPU, limits TCG's advertised VHE feature, and requests the KVM
> HAS_EL2_E2H0 vCPU initialization feature. Unsupported accelerators
> and KVM hosts fail clearly instead of silently ignoring the option.
+ Eric
Adding yet another random property for something that is a feature of
the emulated CPU strikes me as going in the wrong direction.
I'd rather see this being directly driven by Eric's feature framework
as posted at [1], which lets *any* feature being selected by the user.
The KVM feature flag can then be derived from what the user has
selected (and matched against what the host can provide).
Thanks,
M.
[1] https://lore.kernel.org/r/20261010133725.642498-1-eric.auger@redhat.com
--
Without deviation from the norm, progress is not possible.
next prev parent reply other threads:[~2026-11-21 13:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-21 9:56 [PATCH 0/1] hw/arm/virt: add vhe option for nested virtualization Haseeb Ashraf
2026-11-21 9:56 ` [PATCH 1/1] " Haseeb Ashraf
2026-11-21 14:02 ` Mohamed Mediouni
2026-11-21 13:52 ` Marc Zyngier [this message]
2026-11-21 14:01 ` [PATCH 0/1] " Mohamed Mediouni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86qzgez3z8.wl-maz@kernel.org \
--to=maz@kernel.org \
--cc=eauger@redhat.com \
--cc=haseeb.ashraf@siemens.com \
--cc=haseebashraf091@gmail.com \
--cc=kvm@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=pierrick.bouvier@oss.qualcomm.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=volodymyr.babchuk@epam.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox