From: "Alex Bennée" <alex.bennee@linaro.org>
To: Andrew Jones <drjones@redhat.com>
Cc: kvm@vger.kernel.org, pbonzini@redhat.com
Subject: Re: [kvm-unit-tests PATCH 3/3] arm/run: use ACCEL to choose between kvm and tcg
Date: Thu, 06 Aug 2015 19:29:00 +0100 [thread overview]
Message-ID: <87oaikjmoj.fsf@linaro.org> (raw)
In-Reply-To: <1438624311-28713-4-git-send-email-drjones@redhat.com>
Andrew Jones <drjones@redhat.com> writes:
> Inspired by a patch by Alex Bennée. This version uses a new
> unittests.cfg variable and includes support for DRYRUN.
>
> Signed-off-by: Andrew Jones <drjones@redhat.com>
> ---
>
> Another difference with Alex's patch is we no longer output
> 'Running with TCG', as I don't think it's necessary. The
> command line captures that, and the whole point of the patch
> is to silence the '"kvm" accelerator not found.' messages
> anyway.
Yeah that makes sense.
>
> arm/run | 36 ++++++++++++++++++++++++++++++------
> arm/unittests.cfg | 4 +++-
> run_tests.sh | 3 ++-
> scripts/functions.bash | 8 ++++++--
> 4 files changed, 41 insertions(+), 10 deletions(-)
<snip>
I see your re-posting so I'll do a full review then. Is there a branch I
can re-base my stuff on top of for now?
--
Alex Bennée
next prev parent reply other threads:[~2015-08-06 18:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-03 17:51 [kvm-unit-tests PATCH 0/3] tcg is becoming a first class citizen Andrew Jones
2015-08-03 17:51 ` [kvm-unit-tests PATCH 1/3] configure: emit HOST=$host to config.mak Andrew Jones
2015-08-03 17:51 ` [kvm-unit-tests PATCH 2/3] run_tests: pass test name to run script Andrew Jones
2015-08-03 17:51 ` [kvm-unit-tests PATCH 3/3] arm/run: use ACCEL to choose between kvm and tcg Andrew Jones
2015-08-04 7:18 ` Andrew Jones
2015-08-06 18:29 ` Alex Bennée [this message]
2015-08-07 8:00 ` Andrew Jones
-- strict thread matches above, loose matches on Subject: below --
2015-08-04 7:25 [kvm-unit-tests PATCH 0/3] tcg is becoming a first class citizen Andrew Jones
2015-08-04 7:25 ` [kvm-unit-tests PATCH 3/3] arm/run: use ACCEL to choose between kvm and tcg Andrew Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87oaikjmoj.fsf@linaro.org \
--to=alex.bennee@linaro.org \
--cc=drjones@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox