From: "Nikunj A. Dadhania" <nikunj@amd.com>
To: <sashiko-reviews@lists.linux.dev>
Cc: <kvm@vger.kernel.org>
Subject: Re: [PATCH v8 6/8] x86/cpufeatures: Add Page modification logging
Date: Mon, 7 Sep 2026 15:19:04 +0530 [thread overview]
Message-ID: <8eb2e144-2ad0-47b5-876f-bbbab102aca4@amd.com> (raw)
In-Reply-To: <20260907064714.8068E1F00A3A@smtp.kernel.org>
On 9/7/2026 12:17 PM, sashiko-bot@kernel.org wrote:
>> diff --git a/arch/x86/include/asm/cpufeatures.h b/arch/x86/include/asm/cpufeatures.h
>> index f70ee74b5f921..cbfcc66a18e9b 100644
>> --- a/arch/x86/include/asm/cpufeatures.h
>> +++ b/arch/x86/include/asm/cpufeatures.h
>> @@ -238,6 +238,7 @@
>> // free: was #define X86_FEATURE_PVUNLOCK ( 8*32+20) /* PV unlock function */
>> #define X86_FEATURE_VCPUPREEMPT ( 8*32+21) /* PV vcpu_is_preempted function */
>> #define X86_FEATURE_TDX_GUEST ( 8*32+22) /* "tdx_guest" Intel Trust Domain Extensions Guest */
>> +#define X86_FEATURE_PML ( 8*32+23) /* AMD Page Modification logging */
>
> [Severity: Low]
> Does this new feature flag also need to be added to
> tools/arch/x86/include/asm/cpufeatures.h to keep the tools header in sync
> with the main kernel header?
No, as per tools/include/uapi/README, updating tools/ copies of kernel
headers is done by perf/tools maintainers, not the patch submitter.
Regards,
Nikunj
next prev parent reply other threads:[~2026-09-07 9:49 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-07 6:38 [PATCH v8 0/8] KVM: SVM: Add Page Modification Logging (PML) support Nikunj A Dadhania
2026-09-07 6:38 ` [PATCH v8 1/8] KVM: VMX: Pass @vcpu, not @vmx to init_vmcs() Nikunj A Dadhania
2026-09-07 6:39 ` [PATCH v8 2/8] KVM: x86: Move PML page to common vcpu arch structure Nikunj A Dadhania
2026-09-07 6:39 ` [PATCH v8 3/8] KVM: x86: Carve out PML flush routine Nikunj A Dadhania
2026-09-07 6:39 ` [PATCH v8 4/8] KVM: VMX: Use cpu_dirty_log_size instead of enable_pml for PML checks Nikunj A Dadhania
2026-09-07 6:39 ` [PATCH v8 5/8] KVM: x86: Carve out common dirty logging update Nikunj A Dadhania
2026-09-07 6:39 ` [PATCH v8 6/8] x86/cpufeatures: Add Page modification logging Nikunj A Dadhania
2026-09-07 6:47 ` sashiko-bot
2026-09-07 9:49 ` Nikunj A. Dadhania [this message]
2026-09-07 6:39 ` [PATCH v8 7/8] KVM: SVM: Use BIT_ULL for 64-bit misc_ctl bit definitions Nikunj A Dadhania
2026-09-07 6:39 ` [PATCH v8 8/8] KVM: SVM: Add Page modification logging support Nikunj A Dadhania
2026-09-07 7:00 ` sashiko-bot
2026-09-08 4:08 ` Nikunj A. Dadhania
2026-09-10 0:22 ` Sean Christopherson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8eb2e144-2ad0-47b5-876f-bbbab102aca4@amd.com \
--to=nikunj@amd.com \
--cc=kvm@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox