[PATCH] KVM: PPC: Book3S HV: Fix comment typos

[PATCH] KVM: PPC: Book3S HV: Fix comment typos

[Salman Farooq]

Fix two instances of a misspelled word in comments.

Signed-off-by: Salman Farooq <salman.farooq3310@gmail.com>
---
 arch/powerpc/kvm/book3s_hv_uvmem.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/powerpc/kvm/book3s_hv_uvmem.c b/arch/powerpc/kvm/book3s_hv_uvmem.c
index 5fbb95d90e99..6ac8364a7639 100644
--- a/arch/powerpc/kvm/book3s_hv_uvmem.c
+++ b/arch/powerpc/kvm/book3s_hv_uvmem.c
@@ -163,7 +163,7 @@ static DEFINE_SPINLOCK(kvmppc_uvmem_bitmap_lock);
  *  All its GFNs are moved to Normal-GFNs.
  *
  *  UV_TERMINATE transitions the secure-VM back to normal-VM. All
- *  the secure-GFN and shared-GFNs are tranistioned to normal-GFN
+ *  the secure-GFN and shared-GFNs are transitioned to normal-GFN
  *  Note: The contents of the normal-GFN is undefined at this point.
  *
  * GFN state implementation:
@@ -1010,7 +1010,7 @@ static vm_fault_t kvmppc_uvmem_migrate_to_ram(struct vm_fault *vmf)
 /*
  * Release the device PFN back to the pool
  *
- * Gets called when secure GFN tranistions from a secure-PFN
+ * Gets called when secure GFN transitions from a secure-PFN
  * to a normal PFN during H_SVM_PAGE_OUT.
  * Gets called with kvm->arch.uvmem_lock held.
  */
-- 
2.55.0

Re: [PATCH] KVM: PPC: Book3S HV: Fix comment typos

[Ritesh Harjani]

Salman Farooq <salman.farooq3310@gmail.com> writes:

> Fix two instances of a misspelled word in comments.
>

Not sure what this will really get us and what is our maintainer take on
such spelling mistake fixes. I definitely hope we won't churn out a lot
of patches just to fix simple spell mistakes.
But FWIW, the change looks good to me, so:

Reviewed-by: Ritesh Harjani (IBM) <ritesh.list@gmail.com>


> Signed-off-by: Salman Farooq <salman.farooq3310@gmail.com>
> ---
>  arch/powerpc/kvm/book3s_hv_uvmem.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/powerpc/kvm/book3s_hv_uvmem.c b/arch/powerpc/kvm/book3s_hv_uvmem.c
> index 5fbb95d90e99..6ac8364a7639 100644
> --- a/arch/powerpc/kvm/book3s_hv_uvmem.c
> +++ b/arch/powerpc/kvm/book3s_hv_uvmem.c
> @@ -163,7 +163,7 @@ static DEFINE_SPINLOCK(kvmppc_uvmem_bitmap_lock);
>   *  All its GFNs are moved to Normal-GFNs.
>   *
>   *  UV_TERMINATE transitions the secure-VM back to normal-VM. All
> - *  the secure-GFN and shared-GFNs are tranistioned to normal-GFN
> + *  the secure-GFN and shared-GFNs are transitioned to normal-GFN
>   *  Note: The contents of the normal-GFN is undefined at this point.
>   *
>   * GFN state implementation:
> @@ -1010,7 +1010,7 @@ static vm_fault_t kvmppc_uvmem_migrate_to_ram(struct vm_fault *vmf)
>  /*
>   * Release the device PFN back to the pool
>   *
> - * Gets called when secure GFN tranistions from a secure-PFN
> + * Gets called when secure GFN transitions from a secure-PFN
>   * to a normal PFN during H_SVM_PAGE_OUT.
>   * Gets called with kvm->arch.uvmem_lock held.
>   */
> -- 
> 2.55.0

Re: [PATCH] KVM: PPC: Book3S HV: Fix comment typos

[Salman Farooq]

Ritesh Harjani (IBM) <ritesh.list@gmail.com> writes:

> Not sure what this will really get us and what is our maintainer take on
> such spelling mistake fixes. I definitely hope we won't churn out a lot
> of patches just to fix simple spell mistakes.
> But FWIW, the change looks good to me, so:
>
> Reviewed-by: Ritesh Harjani (IBM) <ritesh.list@gmail.com>

Thank you for the review and for taking the time to look at it despite
the reservations, I really appreciate it as a first-time kernel contributor.

Salman

Re: [PATCH] KVM: PPC: Book3S HV: Fix comment typos

[Amit Machhiwal]

On 2026/07/02 08:03 AM, Salman Farooq wrote:
> Fix two instances of a misspelled word in comments.
> 
> Signed-off-by: Salman Farooq <salman.farooq3310@gmail.com>
> ---
>  arch/powerpc/kvm/book3s_hv_uvmem.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

I agree with Ritesh on the amount of churn such misspell fixes may
cause.

Regardless, since this patch has no functional or code change, you may
want to add a 'trivial' suffix to the patch title, e.g.:

  KVM: PPC: Book3S HV: trivial: Fix comment typos

This convention is used to indicate non-functional changes, making it
easier for maintainers to apply without worrying about regressions. See
[1] and [2] for precedent.

[1] https://git.kernel.org/powerpc/c/d2827e5e2e0f0941a651f4b1ca5e9b778c4b5293
[2] https://lore.kernel.org/all/87fr3vvfvq.fsf@vajain21.in.ibm.com/

~Amit

> 
> diff --git a/arch/powerpc/kvm/book3s_hv_uvmem.c b/arch/powerpc/kvm/book3s_hv_uvmem.c
> index 5fbb95d90e99..6ac8364a7639 100644
> --- a/arch/powerpc/kvm/book3s_hv_uvmem.c
> +++ b/arch/powerpc/kvm/book3s_hv_uvmem.c
> @@ -163,7 +163,7 @@ static DEFINE_SPINLOCK(kvmppc_uvmem_bitmap_lock);
>   *  All its GFNs are moved to Normal-GFNs.
>   *
>   *  UV_TERMINATE transitions the secure-VM back to normal-VM. All
> - *  the secure-GFN and shared-GFNs are tranistioned to normal-GFN
> + *  the secure-GFN and shared-GFNs are transitioned to normal-GFN
>   *  Note: The contents of the normal-GFN is undefined at this point.
>   *
>   * GFN state implementation:
> @@ -1010,7 +1010,7 @@ static vm_fault_t kvmppc_uvmem_migrate_to_ram(struct vm_fault *vmf)
>  /*
>   * Release the device PFN back to the pool
>   *
> - * Gets called when secure GFN tranistions from a secure-PFN
> + * Gets called when secure GFN transitions from a secure-PFN
>   * to a normal PFN during H_SVM_PAGE_OUT.
>   * Gets called with kvm->arch.uvmem_lock held.
>   */
> -- 
> 2.55.0
> 

Re: [PATCH] KVM: PPC: Book3S HV: Fix comment typos

[Salman Farooq]

Amit Machhiwal <amachhiw@linux.ibm.com> writes:

> Regardless, since this patch has no functional or code change, you may
> want to add a 'trivial' suffix to the patch title, e.g.:
>
>   KVM: PPC: Book3S HV: trivial: Fix comment typos

Thanks for pointing that out, and for the very useful references.
I wasn't aware of this convention. I will follow it and read up on
other conventions for future patches.

Salman