Kernel KVM virtualization development
 help / color / mirror / Atom feed
* [PATCH] KVM: PPC: Fix callback check in kvmppc_gsm_refresh_info
@ 2026-09-01 13:26 nhuquynh
  0 siblings, 0 replies; only message in thread
From: nhuquynh @ 2026-09-01 13:26 UTC (permalink / raw)
  To: Maddy; +Cc: Npiggin, Mpe, Chleroy, Linuxppc Dev, Kvm, Linux Kernel

From 80fd05e6d156d5a90d4908f2498bf6cc7acbdefd Mon Sep 17 00:00:00 2001
From: Bui Nguyen Nhu Quynh <nhuquynh@tutamail.com>
Date: Tue, 1 Sep 2026 19:39:49 +0700
Subject: [PATCH] KVM: PPC: Fix callback check in kvmppc_gsm_refresh_info

The kvmppc_gsm_refresh_info() function incorrectly checks for the
presence of the fill_info callback instead of refresh_info.

This can lead to:
- NULL pointer dereference if refresh_info is NULL but fill_info is present
- EINVAL return if refresh_info is present but fill_info is NULL

Fix this by checking the correct callback.

Fixes: 6ccbbc33f06ad ("KVM: PPC: Add helper library for Guest State Buffers")
Signed-off-by: Bui Nguyen Nhu Quynh <nhuquynh@tutamail.com>
---
arch/powerpc/kvm/guest-state-buffer.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/powerpc/kvm/guest-state-buffer.c b/arch/powerpc/kvm/guest-state-buffer.c
index 42843eca6727..aeb586ba4523 100644
--- a/arch/powerpc/kvm/guest-state-buffer.c
+++ b/arch/powerpc/kvm/guest-state-buffer.c
@@ -598,7 +598,7 @@ EXPORT_SYMBOL_GPL(kvmppc_gsm_fill_info);
int kvmppc_gsm_refresh_info(struct kvmppc_gs_msg *gsm,
    struct kvmppc_gs_buff *gsb)
{
-	if (!gsm->ops->fill_info)
+	if (!gsm->ops->refresh_info)
return -EINVAL;
 
return gsm->ops->refresh_info(gsm, gsb);
-- 
2.54.0

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2026-09-01 13:27 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-09-01 13:26 [PATCH] KVM: PPC: Fix callback check in kvmppc_gsm_refresh_info nhuquynh

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox