* [PATCH v3 15/17] target/ppc/kvm: Replace alloca() by g_malloc() [not found] <20210507144315.1994337-1-philmd@redhat.com> @ 2021-05-07 14:43 ` Philippe Mathieu-Daudé 2021-05-10 5:38 ` David Gibson 0 siblings, 1 reply; 2+ messages in thread From: Philippe Mathieu-Daudé @ 2021-05-07 14:43 UTC (permalink / raw) To: qemu-devel Cc: Laurent Vivier, Paolo Bonzini, qemu-ppc, Peter Maydell, Alex Bennée, Gerd Hoffmann, qemu-arm, Philippe Mathieu-Daudé, Greg Kurz, David Gibson, open list:Overall KVM CPUs The ALLOCA(3) man-page mentions its "use is discouraged". Use autofree heap allocation instead, replacing it by a g_malloc call. Reviewed-by: Greg Kurz <groug@kaod.org> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> --- target/ppc/kvm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target/ppc/kvm.c b/target/ppc/kvm.c index 104a308abb5..23c4ea377e8 100644 --- a/target/ppc/kvm.c +++ b/target/ppc/kvm.c @@ -2698,11 +2698,11 @@ int kvmppc_save_htab(QEMUFile *f, int fd, size_t bufsize, int64_t max_ns) int kvmppc_load_htab_chunk(QEMUFile *f, int fd, uint32_t index, uint16_t n_valid, uint16_t n_invalid, Error **errp) { - struct kvm_get_htab_header *buf; + g_autofree struct kvm_get_htab_header *buf = NULL; size_t chunksize = sizeof(*buf) + n_valid * HASH_PTE_SIZE_64; ssize_t rc; - buf = alloca(chunksize); + buf = g_malloc(chunksize); buf->index = index; buf->n_valid = n_valid; buf->n_invalid = n_invalid; -- 2.26.3 ^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v3 15/17] target/ppc/kvm: Replace alloca() by g_malloc() 2021-05-07 14:43 ` [PATCH v3 15/17] target/ppc/kvm: Replace alloca() by g_malloc() Philippe Mathieu-Daudé @ 2021-05-10 5:38 ` David Gibson 0 siblings, 0 replies; 2+ messages in thread From: David Gibson @ 2021-05-10 5:38 UTC (permalink / raw) To: Philippe Mathieu-Daudé Cc: qemu-devel, Laurent Vivier, Paolo Bonzini, qemu-ppc, Peter Maydell, Alex Bennée, Gerd Hoffmann, qemu-arm, Greg Kurz, open list:Overall KVM CPUs [-- Attachment #1: Type: text/plain, Size: 1429 bytes --] On Fri, May 07, 2021 at 04:43:13PM +0200, Philippe Mathieu-Daudé wrote: > The ALLOCA(3) man-page mentions its "use is discouraged". > > Use autofree heap allocation instead, replacing it by a g_malloc call. > > Reviewed-by: Greg Kurz <groug@kaod.org> > Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> Acked-by: David Gibson <david@gibson.dropbear.id.au> > --- > target/ppc/kvm.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/target/ppc/kvm.c b/target/ppc/kvm.c > index 104a308abb5..23c4ea377e8 100644 > --- a/target/ppc/kvm.c > +++ b/target/ppc/kvm.c > @@ -2698,11 +2698,11 @@ int kvmppc_save_htab(QEMUFile *f, int fd, size_t bufsize, int64_t max_ns) > int kvmppc_load_htab_chunk(QEMUFile *f, int fd, uint32_t index, > uint16_t n_valid, uint16_t n_invalid, Error **errp) > { > - struct kvm_get_htab_header *buf; > + g_autofree struct kvm_get_htab_header *buf = NULL; > size_t chunksize = sizeof(*buf) + n_valid * HASH_PTE_SIZE_64; > ssize_t rc; > > - buf = alloca(chunksize); > + buf = g_malloc(chunksize); > buf->index = index; > buf->n_valid = n_valid; > buf->n_invalid = n_invalid; -- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 833 bytes --] ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-05-10 5:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20210507144315.1994337-1-philmd@redhat.com>
2021-05-07 14:43 ` [PATCH v3 15/17] target/ppc/kvm: Replace alloca() by g_malloc() Philippe Mathieu-Daudé
2021-05-10 5:38 ` David Gibson
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox