From: Sean Christopherson <seanjc@google.com>
To: Yang Weijiang <weijiang.yang@intel.com>
Cc: pbonzini@redhat.com, kvm@vger.kernel.org
Subject: Re: [kvm-unit-tests PATCH 2/4] x86: Use helpers to fetch supported perf capabilities
Date: Thu, 21 Jul 2022 21:21:17 +0000 [thread overview]
Message-ID: <YtnDTQj72uoN2aj6@google.com> (raw)
In-Reply-To: <20220711041841.126648-3-weijiang.yang@intel.com>
On Mon, Jul 11, 2022, Yang Weijiang wrote:
> - eax.full = id.a;
> - ebx.full = id.b;
> - edx.full = id.d;
> + eax.full = pmu_arch_info();
> + ebx.full = pmu_gp_events();
> + edx.full = pmu_fixed_counters();
Adding helpers for individual fields but then caching the full fields and
ignoring the helpers is silly. It doesn't require much more work to get rid of
the unions entirely (see the pull request I sent to Paolo).
next prev parent reply other threads:[~2022-07-21 21:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-11 4:18 [kvm-unit-tests PATCH 0/4] Fixup and cleanup to pmu test applications Yang Weijiang
2022-07-11 4:18 ` [kvm-unit-tests PATCH 1/4] x86: Use report_skip to print messages when tests are skipped Yang Weijiang
2022-07-11 4:18 ` [kvm-unit-tests PATCH 2/4] x86: Use helpers to fetch supported perf capabilities Yang Weijiang
2022-07-21 21:21 ` Sean Christopherson [this message]
2022-07-22 0:58 ` Yang, Weijiang
2022-07-11 4:18 ` [kvm-unit-tests PATCH 3/4] x86: Skip perf related tests when platform cannot support Yang Weijiang
2022-07-11 4:18 ` [kvm-unit-tests PATCH 4/4] x86: Check platform pmu capabilities before run lbr tests Yang Weijiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YtnDTQj72uoN2aj6@google.com \
--to=seanjc@google.com \
--cc=kvm@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=weijiang.yang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox