From: "Yang, Weijiang" <weijiang.yang@intel.com>
To: Sean Christopherson <seanjc@google.com>
Cc: pbonzini@redhat.com, kvm@vger.kernel.org
Subject: Re: [kvm-unit-tests PATCH 2/4] x86: Use helpers to fetch supported perf capabilities
Date: Fri, 22 Jul 2022 08:58:30 +0800 [thread overview]
Message-ID: <f624e60b-408f-5dba-eae3-daac6bf6b546@intel.com> (raw)
In-Reply-To: <YtnDTQj72uoN2aj6@google.com>
On 7/22/2022 5:21 AM, Sean Christopherson wrote:
> On Mon, Jul 11, 2022, Yang Weijiang wrote:
>> - eax.full = id.a;
>> - ebx.full = id.b;
>> - edx.full = id.d;
>> + eax.full = pmu_arch_info();
>> + ebx.full = pmu_gp_events();
>> + edx.full = pmu_fixed_counters();
> Adding helpers for individual fields but then caching the full fields and
> ignoring the helpers is silly. It doesn't require much more work to get rid of
> the unions entirely (see the pull request I sent to Paolo).
Thank you Sean!
I was not sure if it's suitable to do so, then got this half-done patch :-D.
next prev parent reply other threads:[~2022-07-22 0:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-11 4:18 [kvm-unit-tests PATCH 0/4] Fixup and cleanup to pmu test applications Yang Weijiang
2022-07-11 4:18 ` [kvm-unit-tests PATCH 1/4] x86: Use report_skip to print messages when tests are skipped Yang Weijiang
2022-07-11 4:18 ` [kvm-unit-tests PATCH 2/4] x86: Use helpers to fetch supported perf capabilities Yang Weijiang
2022-07-21 21:21 ` Sean Christopherson
2022-07-22 0:58 ` Yang, Weijiang [this message]
2022-07-11 4:18 ` [kvm-unit-tests PATCH 3/4] x86: Skip perf related tests when platform cannot support Yang Weijiang
2022-07-11 4:18 ` [kvm-unit-tests PATCH 4/4] x86: Check platform pmu capabilities before run lbr tests Yang Weijiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f624e60b-408f-5dba-eae3-daac6bf6b546@intel.com \
--to=weijiang.yang@intel.com \
--cc=kvm@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=seanjc@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox