From: Dave Hansen <dave.hansen@intel.com>
To: "Edgecombe, Rick P" <rick.p.edgecombe@intel.com>,
"Li, Xiaoyao" <xiaoyao.li@intel.com>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"binbin.wu@linux.intel.com" <binbin.wu@linux.intel.com>,
"x86@kernel.org" <x86@kernel.org>
Cc: "Verma, Vishal L" <vishal.l.verma@intel.com>,
"pbonzini@redhat.com" <pbonzini@redhat.com>,
"seanjc@google.com" <seanjc@google.com>,
"Gao, Chao" <chao.gao@intel.com>,
"kas@kernel.org" <kas@kernel.org>
Subject: Re: [PATCH 2/2] x86/cpu: Skip reading MSR_IA32_PLATFORM_ID in virtualized environment
Date: Tue, 28 Apr 2026 12:13:24 -0700 [thread overview]
Message-ID: <a4665b49-dccb-4f99-8472-3dca005f2242@intel.com> (raw)
In-Reply-To: <02608364855a47fdec6e519470321e1522435990.camel@intel.com>
On 4/28/26 11:54, Edgecombe, Rick P wrote:
> From the series with the blamed commit:
> Today, the only code that cares about the platform ID is the microcode
> update code itself. To facilitate storing the platform ID in a more
> generic place and using it outside of the microcode update itself, put
> the enumeration into a helper function.
>
> But it is still only used for microcode stuff AFAICT... It seems it was just
> moved to be "consistent with the other fields which can be matched".
Right. The one place it is being queried is right next to the microcode
version being queried. The microcode version is a field in that info
structure, so the path of least resistance is to put the platform ID in
there too. It also just happened to fit in an existing hole so it
doesn't increase the size of the structure either.
prev parent reply other threads:[~2026-04-28 19:13 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-28 2:47 [PATCH 0/2] Fix MSR_IA32_PLATFORM_ID access for TDX guests Binbin Wu
2026-04-28 2:47 ` [PATCH 1/2] KVM: TDX: Allow TDs to read MSR_IA32_PLATFORM_ID Binbin Wu
2026-04-28 5:31 ` Xiaoyao Li
2026-04-28 11:44 ` Chao Gao
2026-04-28 16:30 ` Sean Christopherson
2026-04-28 18:31 ` Edgecombe, Rick P
2026-04-28 18:44 ` Sean Christopherson
2026-04-28 19:28 ` Edgecombe, Rick P
2026-04-28 18:49 ` Dave Hansen
2026-04-28 2:47 ` [PATCH 2/2] x86/cpu: Skip reading MSR_IA32_PLATFORM_ID in virtualized environment Binbin Wu
2026-04-28 6:01 ` Xiaoyao Li
2026-04-28 9:57 ` Binbin Wu
2026-04-28 18:54 ` Edgecombe, Rick P
2026-04-28 19:13 ` Dave Hansen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a4665b49-dccb-4f99-8472-3dca005f2242@intel.com \
--to=dave.hansen@intel.com \
--cc=binbin.wu@linux.intel.com \
--cc=chao.gao@intel.com \
--cc=kas@kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=rick.p.edgecombe@intel.com \
--cc=seanjc@google.com \
--cc=vishal.l.verma@intel.com \
--cc=x86@kernel.org \
--cc=xiaoyao.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox