From: Sean Christopherson <seanjc@google.com>
To: Yosry Ahmed <yosry@kernel.org>
Cc: Nikunj A Dadhania <nikunj@amd.com>,
kvm@vger.kernel.org, pbonzini@redhat.com,
thomas.lendacky@amd.com, bp@alien8.de,
joao.m.martins@oracle.com, kai.huang@intel.com
Subject: Re: [PATCH v6 7/7] KVM: SVM: Add Page modification logging support
Date: Tue, 21 Apr 2026 16:15:24 -0700 [thread overview]
Message-ID: <aegFDBWMUvhR53c1@google.com> (raw)
In-Reply-To: <aegCKy-4wxRq2jou@google.com>
On Tue, Apr 21, 2026, Yosry Ahmed wrote:
> > @@ -3253,6 +3278,54 @@ static int bus_lock_exit(struct kvm_vcpu *vcpu)
> > return 0;
> > }
> >
> > +void svm_update_cpu_dirty_logging(struct kvm_vcpu *vcpu)
> > +{
> > + struct vcpu_svm *svm = to_svm(vcpu);
> > +
> > + if (WARN_ON_ONCE(!vcpu->kvm->arch.cpu_dirty_log_size))
> > + return;
> > +
> > + guard(svm_vmcb01)(vcpu);
>
> Why do we need this? Why not update vmcb01 directly below?
Yeah, I don't see the point of patch 6. guard(svm_vmcb01) doesn't exist in the
current code base because it's not needed.
> IIUC VMX needs this because it updates the loaded VMCS, but the VMCB is
> just memory.
Yep. If VMWRITE could target an arbitrary VMCS pointer, VMX wouldn't need the
helper either.
next prev parent reply other threads:[~2026-04-21 23:15 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-07 6:32 [PATCH v6 0/7] KVM: SVM: Add Page Modification Logging (PML) support Nikunj A Dadhania
2026-04-07 6:32 ` [PATCH v6 1/7] KVM: x86: Carve out PML flush routine Nikunj A Dadhania
2026-04-07 6:32 ` [PATCH v6 2/7] KVM: x86: Move PML page to common vcpu arch structure Nikunj A Dadhania
2026-04-07 6:32 ` [PATCH v6 3/7] KVM: VMX: Use cpu_dirty_log_size instead of enable_pml for PML checks Nikunj A Dadhania
2026-04-07 6:32 ` [PATCH v6 4/7] x86/cpufeatures: Add Page modification logging Nikunj A Dadhania
2026-04-07 6:32 ` [PATCH v6 5/7] KVM: SVM: Use BIT_ULL for 64-bit nested_ctl bit definitions Nikunj A Dadhania
2026-04-07 6:32 ` [PATCH v6 6/7] KVM: nSVM: Add helpers to temporarily switch to vmcb01 Nikunj A Dadhania
2026-04-07 6:32 ` [PATCH v6 7/7] KVM: SVM: Add Page modification logging support Nikunj A Dadhania
2026-04-20 6:38 ` Nikunj A. Dadhania
2026-04-21 15:08 ` Sean Christopherson
2026-04-21 23:50 ` Huang, Kai
2026-04-22 0:30 ` Sean Christopherson
2026-04-22 1:42 ` Huang, Kai
2026-04-22 5:59 ` Nikunj A. Dadhania
2026-04-22 8:14 ` Huang, Kai
2026-04-21 23:04 ` Yosry Ahmed
2026-04-21 23:15 ` Sean Christopherson [this message]
2026-04-22 6:26 ` Nikunj A. Dadhania
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aegFDBWMUvhR53c1@google.com \
--to=seanjc@google.com \
--cc=bp@alien8.de \
--cc=joao.m.martins@oracle.com \
--cc=kai.huang@intel.com \
--cc=kvm@vger.kernel.org \
--cc=nikunj@amd.com \
--cc=pbonzini@redhat.com \
--cc=thomas.lendacky@amd.com \
--cc=yosry@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox