* [PATCH v3] vfio: selftests: Find devices that have VFIO selftest drivers
@ 2026-05-15 3:07 Josh Hilke
2026-05-19 18:01 ` David Matlack
0 siblings, 1 reply; 2+ messages in thread
From: Josh Hilke @ 2026-05-15 3:07 UTC (permalink / raw)
To: Alex Williamson, David Matlack
Cc: Sean Christopherson, Vipin Sharma, kvm, linux-kernel, Josh Hilke
Add a new script, list_devices.sh, which prints out the
segment:bus:device.function (SBDF) numbers and names of devices on a machine that have a
VFIO selftest driver. This makes it easier to determine if the system is
capable of running VFIO selftests.
Includes a -q (quiet) argument which prints just the SBDFs so that the
output can be piped into tools/testing/selftests/vfio/script/setup.sh to
bind the devices to VFIO to use in VFIO selftests.
Examples:
$ ./list_devices.sh
0000:6a:01.0 - Intel SPR DSA (8086:0b25)
0000:6f:01.0 - Intel SPR DSA (8086:0b25)
0000:74:01.0 - Intel SPR DSA (8086:0b25)
0000:79:01.0 - Intel SPR DSA (8086:0b25)
0000:e7:01.0 - Intel SPR DSA (8086:0b25)
0000:ec:01.0 - Intel SPR DSA (8086:0b25)
0000:f1:01.0 - Intel SPR DSA (8086:0b25)
0000:f6:01.0 - Intel SPR DSA (8086:0b25)
$ ./list_devices.sh -q
0000:6a:01.0
0000:6f:01.0
0000:74:01.0
0000:79:01.0
0000:e7:01.0
0000:ec:01.0
0000:f1:01.0
0000:f6:01.0
Suggested-by: Sean Christopherson <seanjc@google.com>
Signed-off-by: Josh Hilke <jrhilke@google.com>
---
Changelog:
v3:
- Show the names of the devices (Sean)
v2:
- Move the functionality to discover devices from setup.sh into its own script (Sean)
- Omit the patch which automates binding devices to VFIO (Sean, David)
v2: https://lore.kernel.org/kvm/20260414230943.41198-2-jrhilke@google.com/
v1: https://lore.kernel.org/kvm/20260409015139.2800185-1-jrhilke@google.com/
tools/testing/selftests/vfio/Makefile | 1 +
.../selftests/vfio/scripts/list_devices.sh | 46 +++++++++++++++++++
2 files changed, 47 insertions(+)
create mode 100755 tools/testing/selftests/vfio/scripts/list_devices.sh
diff --git a/tools/testing/selftests/vfio/Makefile b/tools/testing/selftests/vfio/Makefile
index 0684932d91bf..777f91f09057 100644
--- a/tools/testing/selftests/vfio/Makefile
+++ b/tools/testing/selftests/vfio/Makefile
@@ -15,6 +15,7 @@ TEST_GEN_PROGS += vfio_pci_driver_test
TEST_FILES += scripts/cleanup.sh
TEST_FILES += scripts/lib.sh
+TEST_FILES += scripts/list_devices.sh
TEST_FILES += scripts/run.sh
TEST_FILES += scripts/setup.sh
diff --git a/tools/testing/selftests/vfio/scripts/list_devices.sh b/tools/testing/selftests/vfio/scripts/list_devices.sh
new file mode 100755
index 000000000000..8e7cbe5b7449
--- /dev/null
+++ b/tools/testing/selftests/vfio/scripts/list_devices.sh
@@ -0,0 +1,46 @@
+#!/bin/bash
+# SPDX-License-Identifier: GPL-2.0-or-later
+
+# List of devices which have a VFIO selftest driver
+readonly DEVICES=(
+ "8086:0b25,Intel SPR DSA"
+ "8086:11fb,Intel GNR-D DSA"
+ "8086:1212,Intel DR DSA"
+ "8086:0cf8,Intel CBDMA"
+)
+
+QUIET=false
+while getopts "q" opt; do
+ case $opt in
+ q) QUIET=true ;;
+ \?) echo "Usage: $0 [-q]" >&2; exit 1 ;;
+ esac
+done
+
+# Print the segment:bus:device.function numbers of PCI devices that can be used
+# to run VFIO selftests.
+function main() {
+ local id_name
+ local name
+ local bdfs
+ local bdf
+ local id
+
+ for id_name in "${DEVICES[@]}"; do
+ IFS=',' read -r id name <<< "$id_name"
+ bdfs=$(lspci -D -d "${id}" | awk '{print $1}')
+
+ [[ -z $bdfs ]] && continue
+
+ if [ "$QUIET" = true ]; then
+ echo "${bdfs}"
+ continue
+ fi
+
+ while read -r bdf; do
+ echo "${bdf} - ${name} (${id})"
+ done <<< "$bdfs"
+ done
+}
+
+main
--
2.54.0.563.g4f69b47b94-goog
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v3] vfio: selftests: Find devices that have VFIO selftest drivers
2026-05-15 3:07 [PATCH v3] vfio: selftests: Find devices that have VFIO selftest drivers Josh Hilke
@ 2026-05-19 18:01 ` David Matlack
0 siblings, 0 replies; 2+ messages in thread
From: David Matlack @ 2026-05-19 18:01 UTC (permalink / raw)
To: Josh Hilke
Cc: Alex Williamson, Sean Christopherson, Vipin Sharma, kvm,
linux-kernel
On 2026-05-15 03:07 AM, Josh Hilke wrote:
> Add a new script, list_devices.sh, which prints out the
> segment:bus:device.function (SBDF) numbers and names of devices on a machine that have a
> VFIO selftest driver. This makes it easier to determine if the system is
> capable of running VFIO selftests.
>
> Includes a -q (quiet) argument which prints just the SBDFs so that the
> output can be piped into tools/testing/selftests/vfio/script/setup.sh to
> bind the devices to VFIO to use in VFIO selftests.
>
> Examples:
>
> $ ./list_devices.sh
> 0000:6a:01.0 - Intel SPR DSA (8086:0b25)
> 0000:6f:01.0 - Intel SPR DSA (8086:0b25)
> 0000:74:01.0 - Intel SPR DSA (8086:0b25)
> 0000:79:01.0 - Intel SPR DSA (8086:0b25)
> 0000:e7:01.0 - Intel SPR DSA (8086:0b25)
> 0000:ec:01.0 - Intel SPR DSA (8086:0b25)
> 0000:f1:01.0 - Intel SPR DSA (8086:0b25)
> 0000:f6:01.0 - Intel SPR DSA (8086:0b25)
>
> $ ./list_devices.sh -q
> 0000:6a:01.0
> 0000:6f:01.0
> 0000:74:01.0
> 0000:79:01.0
> 0000:e7:01.0
> 0000:ec:01.0
> 0000:f1:01.0
> 0000:f6:01.0
>
> Suggested-by: Sean Christopherson <seanjc@google.com>
> Signed-off-by: Josh Hilke <jrhilke@google.com>
> ---
> Changelog:
>
> v3:
> - Show the names of the devices (Sean)
>
> v2:
> - Move the functionality to discover devices from setup.sh into its own script (Sean)
> - Omit the patch which automates binding devices to VFIO (Sean, David)
>
> v2: https://lore.kernel.org/kvm/20260414230943.41198-2-jrhilke@google.com/
> v1: https://lore.kernel.org/kvm/20260409015139.2800185-1-jrhilke@google.com/
>
> tools/testing/selftests/vfio/Makefile | 1 +
> .../selftests/vfio/scripts/list_devices.sh | 46 +++++++++++++++++++
> 2 files changed, 47 insertions(+)
> create mode 100755 tools/testing/selftests/vfio/scripts/list_devices.sh
>
> diff --git a/tools/testing/selftests/vfio/Makefile b/tools/testing/selftests/vfio/Makefile
> index 0684932d91bf..777f91f09057 100644
> --- a/tools/testing/selftests/vfio/Makefile
> +++ b/tools/testing/selftests/vfio/Makefile
> @@ -15,6 +15,7 @@ TEST_GEN_PROGS += vfio_pci_driver_test
>
> TEST_FILES += scripts/cleanup.sh
> TEST_FILES += scripts/lib.sh
> +TEST_FILES += scripts/list_devices.sh
> TEST_FILES += scripts/run.sh
> TEST_FILES += scripts/setup.sh
>
> diff --git a/tools/testing/selftests/vfio/scripts/list_devices.sh b/tools/testing/selftests/vfio/scripts/list_devices.sh
> new file mode 100755
> index 000000000000..8e7cbe5b7449
> --- /dev/null
> +++ b/tools/testing/selftests/vfio/scripts/list_devices.sh
> @@ -0,0 +1,46 @@
> +#!/bin/bash
> +# SPDX-License-Identifier: GPL-2.0-or-later
> +
> +# List of devices which have a VFIO selftest driver
> +readonly DEVICES=(
> + "8086:0b25,Intel SPR DSA"
> + "8086:11fb,Intel GNR-D DSA"
> + "8086:1212,Intel DR DSA"
> + "8086:0cf8,Intel CBDMA"
> +)
> +
> +QUIET=false
> +while getopts "q" opt; do
> + case $opt in
> + q) QUIET=true ;;
> + \?) echo "Usage: $0 [-q]" >&2; exit 1 ;;
> + esac
> +done
Please move the argument parsing into main().
> +
> +# Print the segment:bus:device.function numbers of PCI devices that can be used
> +# to run VFIO selftests.
> +function main() {
> + local id_name
> + local name
> + local bdfs
> + local bdf
> + local id
> +
> + for id_name in "${DEVICES[@]}"; do
> + IFS=',' read -r id name <<< "$id_name"
> + bdfs=$(lspci -D -d "${id}" | awk '{print $1}')
> +
> + [[ -z $bdfs ]] && continue
> +
> + if [ "$QUIET" = true ]; then
nit: Consider using empty string to represent false so that this can
just be:
if [ "$QUIET" ]; then
> + echo "${bdfs}"
> + continue
> + fi
> +
> + while read -r bdf; do
> + echo "${bdf} - ${name} (${id})"
> + done <<< "$bdfs"
nit: This can be a simpler one-liner and also moved into the else case
of the if above to make the execution flow easier to read:
if [ "$quiet" ]; then
echo "${bdfs}"
else
echo "${bdfs}" | sed "s|$| - ${name} (${id})|"
fi
> + done
> +}
> +
> +main
> --
> 2.54.0.563.g4f69b47b94-goog
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-05-19 18:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-05-15 3:07 [PATCH v3] vfio: selftests: Find devices that have VFIO selftest drivers Josh Hilke
2026-05-19 18:01 ` David Matlack
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox