From: Sean Christopherson <seanjc@google.com>
To: Josh Hilke <jrhilke@google.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
David Matlack <dmatlack@google.com>,
Alex Williamson <alex@shazbot.org>
Subject: Re: [PATCH v3 00/16] KVM: selftests: Link with VFIO selftests lib and test device interrupts
Date: Tue, 26 May 2026 18:50:50 -0700 [thread overview]
Message-ID: <ahZN-sGaveY2_JDY@google.com> (raw)
In-Reply-To: <20260421231557.1254270-1-jrhilke@google.com>
On Tue, Apr 21, 2026, Josh Hilke wrote:
> v3:
> - Split monolithic test patch into smaller, logical patches (Sean).
Needs to go farther. E.g. "KVM: selftests: Verify vCPU migration during IRQ delivery"
should be ~4 patches:
1. Add gettid() wrapper (because what you proposed doesn't compile for me).
2. Add sched_getaffinity() wrapper *AND* convert existing users.
3. Add pin_task_to_random_cpu()
4. Implement IRQ bypass vCPU migration
Maybe combine #3 and #4? Adding helpers/APIs without users isn't ideal, but
pin_task_to_random_cpu() is interesting enough that I think it's worth isolating
in this case.
> David Matlack (13):
> KVM: selftests: Build and link sefltests/vfio/lib into KVM selftests
> KVM: selftests: Add /proc/interrupts parsing helpers
> KVM: selftests: Add guest read/write macros
> KVM: selftests: Add IRQ injection test
> KVM: selftests: Verify device IRQs are routed to vCPUs
> KVM: selftests: Verify IRQ affinity changes
> KVM: selftests: Verify IRQs wake up halted vCPUs
> KVM: selftests: Verify dynamic IRQ routing updates
> KVM: selftests: Configure number of IRQs
> KVM: selftests: Verify non-postable IRQ remapping
> KVM: selftests: Verify vCPU migration during IRQ delivery
> KVM: selftests: Configure number of vCPUs
> KVM: selftests: Add xAPIC support
All of these shortlogs need more context. E.g. "Add xAPIC support" suggests the
patch adds xAPIC support to _all_ of selftests. We generally discourage trying
to set the scope to a specific test, because it inevitably falls apart, but it's
easy enough to "manually" call out the relevant test.
KVM: selftests: Add xAPIC support to the IRQ bypass test
> Josh Hilke (3):
> KVM: selftests: Rename guest_rng to kvm_rng
> KVM: selftests: Add helper to generate random u64 in range [min,max]
> KVM: selftests: Print vCPU affinity on timeout
>
> tools/testing/selftests/kvm/Makefile.kvm | 7 +-
> .../selftests/kvm/dirty_log_perf_test.c | 4 +-
> tools/testing/selftests/kvm/dirty_log_test.c | 8 +-
> .../selftests/kvm/include/kvm_syscalls.h | 6 +
> .../testing/selftests/kvm/include/kvm_util.h | 13 +
> .../testing/selftests/kvm/include/proc_util.h | 28 ++
> .../testing/selftests/kvm/include/test_util.h | 26 +-
> .../selftests/kvm/include/x86/kvm_util_arch.h | 4 +-
> tools/testing/selftests/kvm/irq_test.c | 367 ++++++++++++++++++
> tools/testing/selftests/kvm/lib/kvm_util.c | 88 ++++-
> tools/testing/selftests/kvm/lib/memstress.c | 8 +-
> tools/testing/selftests/kvm/lib/proc_util.c | 62 +++
> tools/testing/selftests/kvm/lib/test_util.c | 22 +-
> tools/testing/selftests/kvm/mmu_stress_test.c | 9 +-
> tools/testing/selftests/kvm/steal_time.c | 21 +-
> 15 files changed, 615 insertions(+), 58 deletions(-)
> create mode 100644 tools/testing/selftests/kvm/include/proc_util.h
> create mode 100644 tools/testing/selftests/kvm/irq_test.c
> create mode 100644 tools/testing/selftests/kvm/lib/proc_util.c
>
> --
> 2.54.0.rc2.533.g4f5dca5207-goog
>
prev parent reply other threads:[~2026-05-27 1:50 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-21 23:15 [PATCH v3 00/16] KVM: selftests: Link with VFIO selftests lib and test device interrupts Josh Hilke
2026-04-21 23:15 ` [PATCH v3 01/16] KVM: selftests: Build and link sefltests/vfio/lib into KVM selftests Josh Hilke
2026-04-21 23:15 ` [PATCH v3 02/16] KVM: selftests: Add /proc/interrupts parsing helpers Josh Hilke
2026-04-21 23:15 ` [PATCH v3 03/16] KVM: selftests: Add guest read/write macros Josh Hilke
2026-05-27 1:52 ` Sean Christopherson
2026-05-28 23:01 ` Josh Hilke
2026-05-28 23:08 ` Sean Christopherson
2026-04-21 23:15 ` [PATCH v3 04/16] KVM: selftests: Rename guest_rng to kvm_rng Josh Hilke
2026-04-21 23:15 ` [PATCH v3 05/16] KVM: selftests: Add helper to generate random u64 in range [min,max] Josh Hilke
2026-05-27 1:58 ` Sean Christopherson
2026-05-28 23:01 ` Josh Hilke
2026-04-21 23:15 ` [PATCH v3 06/16] KVM: selftests: Add IRQ injection test Josh Hilke
2026-05-27 1:59 ` Sean Christopherson
[not found] ` <CAAdrzjs37a-hEneORNmzOvOkh4TX4Dmn6bWKEm5L4hgmkUO0wA@mail.gmail.com>
2026-05-28 23:14 ` Sean Christopherson
2026-05-27 2:10 ` Sean Christopherson
2026-05-28 23:02 ` Josh Hilke
2026-04-21 23:15 ` [PATCH v3 07/16] KVM: selftests: Verify device IRQs are routed to vCPUs Josh Hilke
2026-04-21 23:15 ` [PATCH v3 08/16] KVM: selftests: Verify IRQ affinity changes Josh Hilke
2026-04-21 23:15 ` [PATCH v3 09/16] KVM: selftests: Verify IRQs wake up halted vCPUs Josh Hilke
2026-04-21 23:15 ` [PATCH v3 10/16] KVM: selftests: Verify dynamic IRQ routing updates Josh Hilke
2026-04-21 23:15 ` [PATCH v3 11/16] KVM: selftests: Configure number of IRQs Josh Hilke
2026-04-21 23:15 ` [PATCH v3 12/16] KVM: selftests: Verify non-postable IRQ remapping Josh Hilke
2026-05-27 2:13 ` Sean Christopherson
2026-05-28 23:03 ` Josh Hilke
2026-04-21 23:15 ` [PATCH v3 13/16] KVM: selftests: Verify vCPU migration during IRQ delivery Josh Hilke
2026-05-27 2:23 ` Sean Christopherson
2026-05-28 23:05 ` Josh Hilke
2026-05-28 23:24 ` Sean Christopherson
2026-04-21 23:15 ` [PATCH v3 14/16] KVM: selftests: Print vCPU affinity on timeout Josh Hilke
2026-04-21 23:15 ` [PATCH v3 15/16] KVM: selftests: Configure number of vCPUs Josh Hilke
2026-04-21 23:15 ` [PATCH v3 16/16] KVM: selftests: Add xAPIC support Josh Hilke
2026-05-27 1:50 ` Sean Christopherson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ahZN-sGaveY2_JDY@google.com \
--to=seanjc@google.com \
--cc=alex@shazbot.org \
--cc=dmatlack@google.com \
--cc=jrhilke@google.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox