Kernel KVM virtualization development
 help / color / mirror / Atom feed
From: Sean Christopherson <seanjc@google.com>
To: Josh Hilke <jrhilke@google.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
	kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
	 David Matlack <dmatlack@google.com>,
	Alex Williamson <alex@shazbot.org>
Subject: Re: [PATCH v3 13/16] KVM: selftests: Verify vCPU migration during IRQ delivery
Date: Thu, 28 May 2026 23:24:36 +0000	[thread overview]
Message-ID: <ahjOtF4c16hVkN36@google.com> (raw)
In-Reply-To: <CAAdrzjuUEX=p0uX6mavaNv318AkgNG29263JPtXJGqjnmfxrfg@mail.gmail.com>

On Thu, May 28, 2026, Josh Hilke wrote:
> On Tue, May 26, 2026 at 7:23 PM Sean Christopherson <seanjc@google.com> wrote:
> >
> > On Tue, Apr 21, 2026, Josh Hilke wrote:
> > > +static inline int gettid(void)
> >
> > gettid() already exists in at least some of my environments:
> 
> Should we just use syscall(__NR_gettid) to avoid any compatibility
> issues? It's only used once in the test.

Hmm, maybe open code it in kvm_gettid()?  And use it straightaway in
tools/testing/selftests/kvm/demand_paging_test.c.

I'm a-ok open coding the syscall() somewhere, but I don't want to end up in a
state where we're open coding it "everywhere".

Oh, nice, "This call is always successful.".  All the more reason to open code
it as kvm_gettid(), as the kvm_ prefix communicates that the function guarantees
success (or fails the test), it just so happens that we don't need to do anything
to guarantee success.  E.g.

static inline pid_t kvm_gettid(void)
{
	/* Per kernel documentation, gettid "is always successful". */
	return syscall(__NR_gettid);
}

  reply	other threads:[~2026-05-28 23:24 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-21 23:15 [PATCH v3 00/16] KVM: selftests: Link with VFIO selftests lib and test device interrupts Josh Hilke
2026-04-21 23:15 ` [PATCH v3 01/16] KVM: selftests: Build and link sefltests/vfio/lib into KVM selftests Josh Hilke
2026-04-21 23:15 ` [PATCH v3 02/16] KVM: selftests: Add /proc/interrupts parsing helpers Josh Hilke
2026-04-21 23:15 ` [PATCH v3 03/16] KVM: selftests: Add guest read/write macros Josh Hilke
2026-05-27  1:52   ` Sean Christopherson
2026-05-28 23:01     ` Josh Hilke
2026-05-28 23:08       ` Sean Christopherson
2026-04-21 23:15 ` [PATCH v3 04/16] KVM: selftests: Rename guest_rng to kvm_rng Josh Hilke
2026-04-21 23:15 ` [PATCH v3 05/16] KVM: selftests: Add helper to generate random u64 in range [min,max] Josh Hilke
2026-05-27  1:58   ` Sean Christopherson
2026-05-28 23:01     ` Josh Hilke
2026-04-21 23:15 ` [PATCH v3 06/16] KVM: selftests: Add IRQ injection test Josh Hilke
2026-05-27  1:59   ` Sean Christopherson
     [not found]     ` <CAAdrzjs37a-hEneORNmzOvOkh4TX4Dmn6bWKEm5L4hgmkUO0wA@mail.gmail.com>
2026-05-28 23:14       ` Sean Christopherson
2026-05-27  2:10   ` Sean Christopherson
2026-05-28 23:02     ` Josh Hilke
2026-04-21 23:15 ` [PATCH v3 07/16] KVM: selftests: Verify device IRQs are routed to vCPUs Josh Hilke
2026-04-21 23:15 ` [PATCH v3 08/16] KVM: selftests: Verify IRQ affinity changes Josh Hilke
2026-04-21 23:15 ` [PATCH v3 09/16] KVM: selftests: Verify IRQs wake up halted vCPUs Josh Hilke
2026-04-21 23:15 ` [PATCH v3 10/16] KVM: selftests: Verify dynamic IRQ routing updates Josh Hilke
2026-04-21 23:15 ` [PATCH v3 11/16] KVM: selftests: Configure number of IRQs Josh Hilke
2026-04-21 23:15 ` [PATCH v3 12/16] KVM: selftests: Verify non-postable IRQ remapping Josh Hilke
2026-05-27  2:13   ` Sean Christopherson
2026-05-28 23:03     ` Josh Hilke
2026-04-21 23:15 ` [PATCH v3 13/16] KVM: selftests: Verify vCPU migration during IRQ delivery Josh Hilke
2026-05-27  2:23   ` Sean Christopherson
2026-05-28 23:05     ` Josh Hilke
2026-05-28 23:24       ` Sean Christopherson [this message]
2026-04-21 23:15 ` [PATCH v3 14/16] KVM: selftests: Print vCPU affinity on timeout Josh Hilke
2026-04-21 23:15 ` [PATCH v3 15/16] KVM: selftests: Configure number of vCPUs Josh Hilke
2026-04-21 23:15 ` [PATCH v3 16/16] KVM: selftests: Add xAPIC support Josh Hilke
2026-05-27  1:50 ` [PATCH v3 00/16] KVM: selftests: Link with VFIO selftests lib and test device interrupts Sean Christopherson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ahjOtF4c16hVkN36@google.com \
    --to=seanjc@google.com \
    --cc=alex@shazbot.org \
    --cc=dmatlack@google.com \
    --cc=jrhilke@google.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox