Kernel KVM virtualization development
 help / color / mirror / Atom feed
From: Sean Christopherson <seanjc@google.com>
To: Xiaoyao Li <xiaoyao.li@intel.com>
Cc: Chenyi Qiang <chenyi.qiang@intel.com>,
	kvm@vger.kernel.org,  Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [kvm-unit-tests PATCH v2 2/4] nVMX: Validate DEBUGCTLMSR_BUS_LOCK_DETECT states during VMX transitions
Date: Wed, 27 May 2026 08:20:24 -0700	[thread overview]
Message-ID: <ahcLuHLCyk3DPFOU@google.com> (raw)
In-Reply-To: <eca019cb-142d-4933-8273-0607dd900565@intel.com>

On Wed, May 27, 2026, Xiaoyao Li wrote:
> On 5/27/2026 10:58 PM, Sean Christopherson wrote:
> > On Wed, May 27, 2026, Chenyi Qiang wrote:
> > > On 5/26/2026 8:32 PM, Xiaoyao Li wrote:
> > > > On 5/26/2026 11:16 AM, Chenyi Qiang wrote:
> > > > > diff --git a/x86/unittests.cfg b/x86/unittests.cfg
> > > > > index 48835eba..c8426770 100644
> > > > > --- a/x86/unittests.cfg
> > > > > +++ b/x86/unittests.cfg
> > > > > @@ -471,6 +471,14 @@ arch = x86_64
> > > > >    groups = vmx
> > > > >    timeout = 240
> > > > >    +[vmx_bus_lock_detect_test]
> > > > > +file = vmx.flat
> > > > > +test_args = "vmx_bus_lock_detect_test"
> > > > > +qemu_params = -cpu max,+vmx
> > > > > +arch = x86_64
> > > > > +groups = vmx
> > > > > +timeout = 240
> > 
> > Why does this need a separate config, and with a massive timeout?  This should
> > be nearly instantaneous, no?
> > 
> > Ugh, because you copy+pasted vmx_cet.  That thing doesn't need to exist, the
> > testcase is run by the common "vmx" entry.  I'll send a patch to drop vmx_cet.
> 
> I told Chenyi that to actually be able to test LBR bit, we might need some
> specific QEMU configuration to enable PMU and legacy LBR and it will need a
> specific config.

Ah.  AFAICT, it's just the migratable=no thing?  If so, any reason we can't do
that for the main "vmx" testcase?

diff --git x86/unittests.cfg x86/unittests.cfg
index 48835eba..fad58255 100644
--- x86/unittests.cfg
+++ x86/unittests.cfg
@@ -320,7 +320,7 @@ qemu_params = -cpu max,host-phys-bits
 [vmx]
 file = vmx.flat
 test_args = "-exit_monitor_from_l2_test -ept_access* -vmx_smp* -vmx_vmcs_shadow_test -atomic_switch_overflow_msrs_test -vmx_init_signal_test -vmx_apic_passthrough_tpr_threshold_test -apic_reg_virt_test -virt_x2apic_mode_test -vmx_pf_exception_test -vmx_pf_exception_forced_emulation_test -vmx_pf_no_vpid_test -vmx_pf_invvpid_test -vmx_pf_vpid_test -vmx_basic_vid_test -vmx_eoi_virt_test -vmx_posted_interrupts_test"
-qemu_params = -cpu max,+vmx
+qemu_params = -cpu max,migratable=no,+vmx
 arch = x86_64
 groups = vmx

  reply	other threads:[~2026-05-27 15:20 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-26  3:16 [kvm-unit-tests PATCH v2 0/4] nVMX: Improve IA32_DEBUGCTLMSR test on debug controls Chenyi Qiang
2026-05-26  3:16 ` [kvm-unit-tests PATCH v2 1/4] nVMX: Remove the IA32_DEBUGCTLMSR access in debugctls test Chenyi Qiang
2026-05-26  4:39   ` Xiaoyao Li
2026-05-26  4:52     ` Chenyi Qiang
2026-05-26  3:16 ` [kvm-unit-tests PATCH v2 2/4] nVMX: Validate DEBUGCTLMSR_BUS_LOCK_DETECT states during VMX transitions Chenyi Qiang
2026-05-26 12:32   ` Xiaoyao Li
2026-05-27  1:42     ` Chenyi Qiang
2026-05-27 14:58       ` Sean Christopherson
2026-05-27 15:16         ` Xiaoyao Li
2026-05-27 15:20           ` Sean Christopherson [this message]
2026-05-26  3:16 ` [kvm-unit-tests PATCH v2 3/4] nVMX: Validate DEBUGCTLMSR_RTM_DEBUG " Chenyi Qiang
2026-05-26 12:33   ` Xiaoyao Li
2026-05-26  3:16 ` [kvm-unit-tests PATCH v2 4/4] nVMX: Validate DEBUGCTLMSR_LBR " Chenyi Qiang
2026-05-26 12:34   ` Xiaoyao Li
2026-05-27  2:11     ` Chenyi Qiang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ahcLuHLCyk3DPFOU@google.com \
    --to=seanjc@google.com \
    --cc=chenyi.qiang@intel.com \
    --cc=kvm@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    --cc=xiaoyao.li@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox