From: Sean Christopherson <seanjc@google.com>
To: Ewan Hai <ewandevelop@gmail.com>
Cc: pbonzini@redhat.com, tglx@kernel.org, mingo@redhat.com,
bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org,
hpa@zytor.com, kvm@vger.kernel.org,
linux-kernel@vger.kernel.org, cobechen@zhaoxin.com,
tonywwang@zhaoxin.com
Subject: Re: [PATCH v1 1/5] KVM: x86: Expose Zhaoxin SM2 CPUID feature
Date: Wed, 27 May 2026 19:55:07 -0700 [thread overview]
Message-ID: <aheui4vnxpS7BPtn@google.com> (raw)
In-Reply-To: <CAG2uPc6YKSHWgkxFNb2-AkD731rvU+w4umrKpXDApzHfjE+kFA@mail.gmail.com>
On Thu, May 28, 2026, Ewan Hai wrote:
> Quick question before sending v2:
>
> With the definitions moving to cpufeatures.h, there are two reasonable
> ways to organize the series. Which would you prefer?
>
> Option A (6 patches, split by subsystem):
>
> [PATCH v2 1/6] x86/cpufeatures: Add Zhaoxin SM2 feature
> [PATCH v2 2/6] x86/cpufeatures: Add Zhaoxin CCS (SM3 + SM4) feature
> [PATCH v2 3/6] x86/cpufeatures: Add Zhaoxin RNG2 feature
> [PATCH v2 4/6] x86/cpufeatures: Add Zhaoxin PHE2 feature
> [PATCH v2 5/6] x86/cpufeatures: Add Zhaoxin RSA feature
> [PATCH v2 6/6] KVM: x86: Advertise new Zhaoxin CPUID 0xC0000001 EDX bits
>
> Option B (5 patches, each group end-to-end):
>
> [PATCH v2 1/5] KVM: x86: Expose Zhaoxin SM2 CPUID feature
> [PATCH v2 2/5] KVM: x86: Expose Zhaoxin CCS (SM3 + SM4) CPUID feature
> [PATCH v2 3/5] KVM: x86: Expose Zhaoxin RNG2 CPUID feature
> [PATCH v2 4/5] KVM: x86: Expose Zhaoxin PHE2 CPUID feature
> [PATCH v2 5/5] KVM: x86: Expose Zhaoxin RSA CPUID feature
> (each patch adds both the cpufeatures.h entry and the KVM F() use)
Option B. Thanks!
> Either way the total diff is the same; just want to do it in the form
> that's easiest to review. Any preference?
next prev parent reply other threads:[~2026-05-28 2:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-13 12:48 [PATCH v1 0/5] KVM: x86: Expose Zhaoxin CPUID 0xC0000001 EDX cryptographic features Ewan Hai
2026-05-13 12:48 ` [PATCH v1 1/5] KVM: x86: Expose Zhaoxin SM2 CPUID feature Ewan Hai
2026-05-28 0:26 ` Sean Christopherson
2026-05-28 2:52 ` Ewan Hai
2026-05-28 2:55 ` Sean Christopherson [this message]
2026-05-13 12:48 ` [PATCH v1 2/5] KVM: x86: Expose Zhaoxin CCS (SM3 + SM4) " Ewan Hai
2026-05-13 12:48 ` [PATCH v1 3/5] KVM: x86: Expose Zhaoxin RNG2 " Ewan Hai
2026-05-13 12:48 ` [PATCH v1 4/5] KVM: x86: Expose Zhaoxin PHE2 " Ewan Hai
2026-05-13 12:48 ` [PATCH v1 5/5] KVM: x86: Expose Zhaoxin RSA " Ewan Hai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aheui4vnxpS7BPtn@google.com \
--to=seanjc@google.com \
--cc=bp@alien8.de \
--cc=cobechen@zhaoxin.com \
--cc=dave.hansen@linux.intel.com \
--cc=ewandevelop@gmail.com \
--cc=hpa@zytor.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=tglx@kernel.org \
--cc=tonywwang@zhaoxin.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox