Kernel KVM virtualization development
 help / color / mirror / Atom feed
* [PATCH v6] vfio: selftests: Find devices that have VFIO selftest drivers
@ 2026-06-02 22:29 Josh Hilke
  2026-06-04 19:50 ` Sean Christopherson
  0 siblings, 1 reply; 3+ messages in thread
From: Josh Hilke @ 2026-06-02 22:29 UTC (permalink / raw)
  To: David Matlack, Alex Williamson
  Cc: Sean Christopherson, Vipin Sharma, kvm, linux-kernel, Josh Hilke

Add a new script, list_supported_devices.sh, which prints out the
segment:bus:device.function (SBDF) numbers and names of devices on a
machine that have a VFIO selftest driver. This makes it easier to
determine if the system is capable of running VFIO selftests.

Includes a -q (quiet) argument which prints just the SBDFs so that the
output can be passed to tools/testing/selftests/vfio/scripts/setup.sh
(e.g. via xargs) to bind the devices to VFIO to use in VFIO selftests.

Examples:

$ ./list_supported_devices.sh
0000:6a:01.0 - Intel DSA SPR [8086:0b25]
0000:6f:01.0 - Intel DSA SPR [8086:0b25]
0000:74:01.0 - Intel DSA SPR [8086:0b25]

$ ./list_supported_devices.sh -q
0000:6a:01.0
0000:6f:01.0
0000:74:01.0

Suggested-by: Sean Christopherson <seanjc@google.com>
Signed-off-by: Josh Hilke <jrhilke@google.com>
---
Changelog

v5 -> v6
- Fix typos in commit message (Sashiko)
- Remove unused variable (Sashiko)

v5: https://lore.kernel.org/kvm/20260602185615.3025904-1-jrhilke@google.com/

 tools/testing/selftests/vfio/Makefile         |  1 +
 .../vfio/scripts/list_supported_devices.sh    | 43 +++++++++++++++++++
 2 files changed, 44 insertions(+)
 create mode 100755 tools/testing/selftests/vfio/scripts/list_supported_devices.sh

diff --git a/tools/testing/selftests/vfio/Makefile b/tools/testing/selftests/vfio/Makefile
index 0684932d91bf..127e70b996a9 100644
--- a/tools/testing/selftests/vfio/Makefile
+++ b/tools/testing/selftests/vfio/Makefile
@@ -15,6 +15,7 @@ TEST_GEN_PROGS += vfio_pci_driver_test
 
 TEST_FILES += scripts/cleanup.sh
 TEST_FILES += scripts/lib.sh
+TEST_FILES += scripts/list_supported_devices.sh
 TEST_FILES += scripts/run.sh
 TEST_FILES += scripts/setup.sh
 
diff --git a/tools/testing/selftests/vfio/scripts/list_supported_devices.sh b/tools/testing/selftests/vfio/scripts/list_supported_devices.sh
new file mode 100755
index 000000000000..4a4a2bc41901
--- /dev/null
+++ b/tools/testing/selftests/vfio/scripts/list_supported_devices.sh
@@ -0,0 +1,43 @@
+#!/bin/bash
+# SPDX-License-Identifier: GPL-2.0-or-later
+
+# List of devices which have a VFIO selftest driver. Device IDs are found in the
+# drivers in selftests/vfio/lib/drivers.
+readonly DEVICES=(
+	"8086:0b25,Intel DSA SPR"
+	"8086:11fb,Intel DSA GNR-D"
+	"8086:1212,Intel DSA DMR"
+	"8086:2021,Intel IOAT SKX"
+)
+
+# Print the segment:bus:device.function numbers of PCI devices that can be used
+# to run VFIO selftests.
+function main() {
+	local id_name
+	local quiet=""
+	local name
+	local bdfs
+	local id
+
+	while getopts "q" opt; do
+		case $opt in
+			q) quiet="true" ;;
+			\?) echo "Usage: $0 [-q]" >&2; exit 1 ;;
+		esac
+	done
+
+	for id_name in "${DEVICES[@]}"; do
+		IFS=',' read -r id name <<< "$id_name"
+		bdfs=$(lspci -D -d "${id}" | awk '{print $1}')
+
+		[[ -z $bdfs ]] && continue
+
+		if [ "$quiet" ]; then
+			echo "${bdfs}"
+		else
+			echo "${bdfs}" | sed "s|$| - ${name} [${id}]|"
+		fi
+	done
+}
+
+main "$@"
-- 
2.54.0.1013.g208068f2d8-goog


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH v6] vfio: selftests: Find devices that have VFIO selftest drivers
  2026-06-02 22:29 [PATCH v6] vfio: selftests: Find devices that have VFIO selftest drivers Josh Hilke
@ 2026-06-04 19:50 ` Sean Christopherson
  2026-06-04 20:30   ` David Matlack
  0 siblings, 1 reply; 3+ messages in thread
From: Sean Christopherson @ 2026-06-04 19:50 UTC (permalink / raw)
  To: Josh Hilke
  Cc: David Matlack, Alex Williamson, Vipin Sharma, kvm, linux-kernel

On Tue, Jun 02, 2026, Josh Hilke wrote:
> Add a new script, list_supported_devices.sh, which prints out the
> segment:bus:device.function (SBDF) numbers and names of devices on a
> machine that have a VFIO selftest driver. This makes it easier to
> determine if the system is capable of running VFIO selftests.
> 
> Includes a -q (quiet) argument which prints just the SBDFs so that the
> output can be passed to tools/testing/selftests/vfio/scripts/setup.sh
> (e.g. via xargs) to bind the devices to VFIO to use in VFIO selftests.
> 
> Examples:
> 
> $ ./list_supported_devices.sh
> 0000:6a:01.0 - Intel DSA SPR [8086:0b25]
> 0000:6f:01.0 - Intel DSA SPR [8086:0b25]
> 0000:74:01.0 - Intel DSA SPR [8086:0b25]
> 
> $ ./list_supported_devices.sh -q
> 0000:6a:01.0
> 0000:6f:01.0
> 0000:74:01.0
> 
> Suggested-by: Sean Christopherson <seanjc@google.com>
> Signed-off-by: Josh Hilke <jrhilke@google.com>

NAK, until this stuff is fixed and properly documented.

This script needs to (a) communicate that some of the devices may be on VFIO's
denylist, (b) NOT report them by default, (c) let the user report denylisted
devices, (d) make it *very* clear in the output that a device, and (e) ideally
provide the user with a hint of how that might be able to test a denied device,
e.g. by reloading vfio-pci with disable_denylist=1.

Nothing in here so much as mentions that these "supported" devices may be
disallowed by the kernel, including the devices that's USED AS THE EXAMPLE.

The DSA SPR devices has been on the naughty list since commit 95feb3160eef ("VFIO:
Add the SPR_DSA and SPR_IAX devices to the denylist") from 2024, so I have a
very hard time believing y'all weren't aware of this.  And if you really truly
weren't aware of this quirk, than what exactly are you even testing!?!?

C'mon.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v6] vfio: selftests: Find devices that have VFIO selftest drivers
  2026-06-04 19:50 ` Sean Christopherson
@ 2026-06-04 20:30   ` David Matlack
  0 siblings, 0 replies; 3+ messages in thread
From: David Matlack @ 2026-06-04 20:30 UTC (permalink / raw)
  To: Sean Christopherson
  Cc: Josh Hilke, Alex Williamson, Vipin Sharma, kvm, linux-kernel

On Thu, Jun 4, 2026 at 12:50 PM Sean Christopherson <seanjc@google.com> wrote:
>
> On Tue, Jun 02, 2026, Josh Hilke wrote:
> > Add a new script, list_supported_devices.sh, which prints out the
> > segment:bus:device.function (SBDF) numbers and names of devices on a
> > machine that have a VFIO selftest driver. This makes it easier to
> > determine if the system is capable of running VFIO selftests.
> >
> > Includes a -q (quiet) argument which prints just the SBDFs so that the
> > output can be passed to tools/testing/selftests/vfio/scripts/setup.sh
> > (e.g. via xargs) to bind the devices to VFIO to use in VFIO selftests.
> >
> > Examples:
> >
> > $ ./list_supported_devices.sh
> > 0000:6a:01.0 - Intel DSA SPR [8086:0b25]
> > 0000:6f:01.0 - Intel DSA SPR [8086:0b25]
> > 0000:74:01.0 - Intel DSA SPR [8086:0b25]
> >
> > $ ./list_supported_devices.sh -q
> > 0000:6a:01.0
> > 0000:6f:01.0
> > 0000:74:01.0
> >
> > Suggested-by: Sean Christopherson <seanjc@google.com>
> > Signed-off-by: Josh Hilke <jrhilke@google.com>
>
> NAK, until this stuff is fixed and properly documented.
>
> This script needs to (a) communicate that some of the devices may be on VFIO's
> denylist, (b) NOT report them by default, (c) let the user report denylisted
> devices, (d) make it *very* clear in the output that a device, and (e) ideally
> provide the user with a hint of how that might be able to test a denied device,
> e.g. by reloading vfio-pci with disable_denylist=1.
>
> Nothing in here so much as mentions that these "supported" devices may be
> disallowed by the kernel, including the devices that's USED AS THE EXAMPLE.
>
> The DSA SPR devices has been on the naughty list since commit 95feb3160eef ("VFIO:
> Add the SPR_DSA and SPR_IAX devices to the denylist") from 2024, so I have a
> very hard time believing y'all weren't aware of this.  And if you really truly
> weren't aware of this quirk, than what exactly are you even testing!?!?
>
> C'mon.

Yeah vfio_pci.disable_denylist=Y is required to use the Intel DSA SPR
device. This script is a great place to capture that previously hidden
requirement.

Your proposed (a)-(e) sound good to me.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-06-04 20:31 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-06-02 22:29 [PATCH v6] vfio: selftests: Find devices that have VFIO selftest drivers Josh Hilke
2026-06-04 19:50 ` Sean Christopherson
2026-06-04 20:30   ` David Matlack

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox