Re: [PATCH v6 01/18] KVM: selftests: Build and link selftests/vfio/lib into KVM selftests

[Sean Christopherson <seanjc@google.com>]

On Wed, Jun 10, 2026, sashiko-bot@kernel.org wrote:
> > diff --git a/tools/testing/selftests/kvm/Makefile.kvm b/tools/testing/selftests/kvm/Makefile.kvm
> > index e0ddd3ff9472d..14316358fd9fb 100644
> > --- a/tools/testing/selftests/kvm/Makefile.kvm
> > +++ b/tools/testing/selftests/kvm/Makefile.kvm
> > @@ -257,6 +257,7 @@ OVERRIDE_TARGETS = 1
> >  # which causes the environment variable to override the makefile).
> >  include ../lib.mk
> >  include ../cgroup/lib/libcgroup.mk
> > +include ../vfio/lib/libvfio.mk
> 
> [Severity: Low]
> Does including libvfio.mk here break the "make clean all" sequence for KVM 
> selftests?

David and/or Josh, can you verify whether Sashiko is hallucinating or has a
legitimate concern?

> In tools/testing/selftests/vfio/lib/libvfio.mk, the output directory is
> eagerly created at parse time:
> 
> LIBVFIO_O_DIRS := $(shell dirname $(LIBVFIO_O) | uniq)
> $(shell mkdir -p $(LIBVFIO_O_DIRS))
> 
> The directory is also added to EXTRA_CLEAN. 
> 
> If a developer runs "make clean all", Make will parse the included libvfio.mk 
> and run the shell mkdir command at parse time. Then it executes the clean 
> target, which deletes the newly created libvfio directory. Finally, it 
> executes the all target, but the compilation fails with a "No such file or 
> directory" error because the output directory was deleted and isn't recreated
> in the build recipe.
> 
> >  
> >  INSTALL_HDR_PATH = $(top_srcdir)/usr
> 
> [ ... ]
> 
> -- 
> Sashiko AI review · https://sashiko.dev/#/patchset/20260610005338.2967132-1-seanjc@google.com?part=1