Kernel KVM virtualization development
 help / color / mirror / Atom feed
From: Pekka Enberg <penberg@kernel.org>
To: Sasha Levin <levinsasha928@gmail.com>
Cc: kvm@vger.kernel.org, mingo@elte.hu, asias.hejun@gmail.com,
	gorcunov@gmail.com
Subject: Re: [PATCH 1/3] kvm tools: Make keyboard termination go through regular termination path
Date: Thu, 11 Aug 2011 16:47:53 +0300 (EEST)	[thread overview]
Message-ID: <alpine.DEB.2.00.1108111643200.2531@tiger> (raw)
In-Reply-To: <1313070086.3456.17.camel@lappy>

On Thu, 11 Aug 2011, Sasha Levin wrote:
>> This is a nice cleanup but I'm not happy about the fact that you also nuke
>> the above printf(). Is there a simple way to keep it there?
>>
>
> You get that printf from the normal exit path.

You get a different printf:

$ grep -r "KVM session" *.c
builtin-run.c:		printf("\n  # KVM session ended normally.\n");
term.c:			printf("\n  # KVM session terminated.\n");

It's nice to see that the user terminated the session without going 
through reboot cycle. Dunno how much it matters but it'd be nice to keep 
it since it's already there.

 			Pekka

  reply	other threads:[~2011-08-11 13:47 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-11 12:43 [PATCH 1/3] kvm tools: Make keyboard termination go through regular termination path Sasha Levin
2011-08-11 12:43 ` [PATCH 2/3] kvm tools: Add kvm__trigger_irq() Sasha Levin
2011-08-11 12:43 ` [PATCH 3/3] kvm tools: Add MSI-X support to virtio-net Sasha Levin
2011-08-11 13:33 ` [PATCH 1/3] kvm tools: Make keyboard termination go through regular termination path walimis
2011-08-11 13:39 ` Pekka Enberg
2011-08-11 13:41   ` Sasha Levin
2011-08-11 13:47     ` Pekka Enberg [this message]
2011-08-11 13:48       ` Sasha Levin
2011-08-11 14:04         ` Pekka Enberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.00.1108111643200.2531@tiger \
    --to=penberg@kernel.org \
    --cc=asias.hejun@gmail.com \
    --cc=gorcunov@gmail.com \
    --cc=kvm@vger.kernel.org \
    --cc=levinsasha928@gmail.com \
    --cc=mingo@elte.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox