From: Pekka Enberg <penberg@kernel.org>
To: Sasha Levin <levinsasha928@gmail.com>
Cc: kvm@vger.kernel.org, mingo@elte.hu, asias.hejun@gmail.com,
gorcunov@gmail.com
Subject: Re: [PATCH 1/3] kvm tools: Make keyboard termination go through regular termination path
Date: Thu, 11 Aug 2011 17:04:09 +0300 (EEST) [thread overview]
Message-ID: <alpine.DEB.2.00.1108111702020.2531@tiger> (raw)
In-Reply-To: <1313070518.3456.18.camel@lappy>
On Thu, 11 Aug 2011, Sasha Levin wrote:
>> You get a different printf:
>>
>> $ grep -r "KVM session" *.c
>> builtin-run.c: printf("\n # KVM session ended normally.\n");
>> term.c: printf("\n # KVM session terminated.\n");
>>
>> It's nice to see that the user terminated the session without going
>> through reboot cycle. Dunno how much it matters but it'd be nice to keep
>> it since it's already there.
>
> Hm... In that case, how about changing it to "# KVM session
> terminating..." which will be followed by "# KVM session terminated"
> when the guest is actually dead?
It would just add more noise. Oh well, I applied your patch.
Pekka
prev parent reply other threads:[~2011-08-11 14:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-11 12:43 [PATCH 1/3] kvm tools: Make keyboard termination go through regular termination path Sasha Levin
2011-08-11 12:43 ` [PATCH 2/3] kvm tools: Add kvm__trigger_irq() Sasha Levin
2011-08-11 12:43 ` [PATCH 3/3] kvm tools: Add MSI-X support to virtio-net Sasha Levin
2011-08-11 13:33 ` [PATCH 1/3] kvm tools: Make keyboard termination go through regular termination path walimis
2011-08-11 13:39 ` Pekka Enberg
2011-08-11 13:41 ` Sasha Levin
2011-08-11 13:47 ` Pekka Enberg
2011-08-11 13:48 ` Sasha Levin
2011-08-11 14:04 ` Pekka Enberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.00.1108111702020.2531@tiger \
--to=penberg@kernel.org \
--cc=asias.hejun@gmail.com \
--cc=gorcunov@gmail.com \
--cc=kvm@vger.kernel.org \
--cc=levinsasha928@gmail.com \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox