From: "Maciej W. Rozycki" <macro@linux-mips.org>
To: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Cc: Greg KH <greg@kroah.com>, Paolo Bonzini <pbonzini@redhat.com>,
Jiaxun Yang <jiaxun.yang@flygoat.com>,
Huacai Chen <chenhc@lemote.com>,
Aleksandar Markovic <aleksandar.qemu.devel@gmail.com>,
kvm@vger.kernel.org, linux-mips@vger.kernel.org,
Fuxin Zhang <zhangfx@lemote.com>,
Huacai Chen <chenhuacai@gmail.com>,
stable@vger.kernel.org
Subject: Re: [PATCH] MIPS: VZ: Only include loongson_regs.h for CPU_LOONGSON64
Date: Sat, 22 Aug 2020 19:24:47 +0100 (BST) [thread overview]
Message-ID: <alpine.LFD.2.21.2008221913550.3460685@eddie.linux-mips.org> (raw)
In-Reply-To: <20200810093158.GA6026@alpha.franken.de>
On Mon, 10 Aug 2020, Thomas Bogendoerfer wrote:
> > > It's not just this #include, there's a couple dozen mach-* directories;
> > > changing how they work would be up to the MIPS maintainers (CCed), and
> > > it would certainly not be a patch that can be merged in stable@ kernels.
> > >
> > > arch/mips/kernel/cpu-probe.c has the same
> > >
> > > #ifdef CONFIG_CPU_LOONGSON64
> > > #include <loongson_regs.h>
> > >
> > > for example, so apparently they're good with this. So if I don't pick
> > > up the patch to fix the build it would be in all likelihood merged by
> > > MIPS maintainers. The only difference will be how long the build
> > > remains broken and the fact that they need to worry about KVM despite
> > > the presence of a specific maintainer.
> >
> > Ok, fair enough, but in the long-run, this should probably be fixed up
> > "properly" if this arch is still being maintained.
>
> I have it on my todo list. My plan is to move stuff out of mach-* directories,
> which aren't needed there. This should solve issues like the one here.
Correct, it looks like another maintainer's oversight.
The asm/mach-<platform>/ directories are there for platform variants of
generic stuff found in asm/mach-generic/. So if something is not there in
asm/mach-generic/, then it must not be in any other asm/mach-<plaftorm>/
subdirectory either.
Regular platform headers need to go under asm/<plaftorm>/. Compare
asm/mach-dec/ vs asm/dec/, or asm/mach-sibyte/ vs asm/sibyte/, and so on.
So this `loongson_regs.h' piece belongs to asm/loongson64/ rather than
asm/mach-loongson64/.
Maciej
prev parent reply other threads:[~2020-08-22 18:31 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-08 12:50 [PATCH] MIPS: VZ: Only include loongson_regs.h for CPU_LOONGSON64 Huacai Chen
2020-08-08 15:31 ` Greg KH
2020-08-08 15:35 ` Jiaxun Yang
2020-08-09 7:02 ` Greg KH
2020-08-09 17:23 ` Paolo Bonzini
2020-08-09 17:38 ` Sasha Levin
2020-08-09 17:45 ` Sasha Levin
2020-08-10 7:44 ` Greg KH
2020-08-10 8:56 ` Paolo Bonzini
2020-08-10 9:03 ` Greg KH
2020-08-10 9:29 ` Jiaxun Yang
2020-08-10 9:31 ` Thomas Bogendoerfer
2020-08-22 18:24 ` Maciej W. Rozycki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.21.2008221913550.3460685@eddie.linux-mips.org \
--to=macro@linux-mips.org \
--cc=aleksandar.qemu.devel@gmail.com \
--cc=chenhc@lemote.com \
--cc=chenhuacai@gmail.com \
--cc=greg@kroah.com \
--cc=jiaxun.yang@flygoat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=stable@vger.kernel.org \
--cc=tsbogend@alpha.franken.de \
--cc=zhangfx@lemote.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox