Re: [PATCH v2 4/8] KVM: VMX: Rename posted interrupt prefixes from "vmx" to "vt"

[Sean Christopherson <seanjc@google.com>]

On Wed, Aug 26, 2026, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [Low] Incomplete refactoring: The common helper function `vmx_needs_pi_wakeup` was not renamed to `vt_needs_pi_wakeup`.
> --
> 
> commit 3f6ac2d22873c9d6eb23bb3aab8ab0ad05bd4863
> Author: Sean Christopherson <seanjc@google.com>
> 
> KVM: VMX: Rename posted interrupt prefixes from "vmx" to "vt"
> 
> This commit renames posted interrupt APIs that are shared between VMX and TDX
> to use the "vt" prefix instead of "vmx". This is a non-functional change.
> 
> > diff --git a/arch/x86/kvm/vmx/posted_intr.c b/arch/x86/kvm/vmx/posted_intr.c
> > index 24221ba553be1..359ef3e6ebbe4 100644
> > --- a/arch/x86/kvm/vmx/posted_intr.c
> > +++ b/arch/x86/kvm/vmx/posted_intr.c
> [ ... ]
> > @@ -219,10 +219,10 @@ static bool vmx_needs_pi_wakeup(struct kvm_vcpu *vcpu)
> >  	 * back to the pi_wakeup_handler() function.
> >  	 */
> >  	return (vmx_can_use_ipiv(vcpu) && !is_td_vcpu(vcpu)) ||
> > -		vmx_can_use_vtd_pi(vcpu->kvm);
> > +		vt_can_use_vtd_pi(vcpu->kvm);
> >  }
> 
> [Severity: Low]
> This isn't a bug, but does vmx_needs_pi_wakeup() also need to be renamed to
> vt_needs_pi_wakeup()?

Doh, yes.  I meant to change it, but got distracted by vmx_can_use_ipiv(), which
_is_ VMX specific, and forgot to revisit vmx_needs_pi_wakeup().

If there are no other issues in the series, I'll just fix this one up when
applying.