From: Paolo Bonzini <pbonzini@redhat.com>
To: David Hildenbrand <david@redhat.com>,
Thomas Huth <thuth@redhat.com>,
kvm@vger.kernel.org
Cc: "Radim Krčmář" <rkrcmar@redhat.com>,
"Christian Borntraeger" <borntraeger@de.ibm.com>
Subject: Re: [kvm-unit-tests PATCH v1] s390x: add a pgm irq handler and a way to expect them
Date: Tue, 30 May 2017 12:59:28 +0200 [thread overview]
Message-ID: <b76e549d-63b2-22d5-5729-bbac7f619cd2@redhat.com> (raw)
In-Reply-To: <67569aa2-c95f-e7ac-47dd-ed2939a6c3ae@redhat.com>
On 30/05/2017 10:03, David Hildenbrand wrote:
>>> We need "-fno-delete-null-pointer-checks", otherwise trying to access the
>>> lowcore at address 0 makes GCC generate very weird code.
>> I wonder whether you could get rid of that by using a global variable
>> for lc instead?
> As far as I remember, I tried that and it didn't change a thing. Will do
> a quick test.
>
-fno-delete-null-pointer-checks is the right thing to do, trying to hide
undefined behavior from the compiler leads to misery. :)
Paolo
prev parent reply other threads:[~2017-05-30 10:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-29 12:17 [kvm-unit-tests PATCH v1] s390x: add a pgm irq handler and a way to expect them David Hildenbrand
2017-05-29 14:24 ` David Hildenbrand
2017-05-29 16:35 ` Thomas Huth
2017-05-30 8:03 ` David Hildenbrand
2017-05-30 8:24 ` David Hildenbrand
2017-05-30 10:59 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b76e549d-63b2-22d5-5729-bbac7f619cd2@redhat.com \
--to=pbonzini@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=david@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=rkrcmar@redhat.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox