public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: David Hildenbrand <david@redhat.com>
To: Thomas Huth <thuth@redhat.com>, kvm@vger.kernel.org
Cc: "Paolo Bonzini" <pbonzini@redhat.com>,
	"Radim Krčmář" <rkrcmar@redhat.com>,
	"Christian Borntraeger" <borntraeger@de.ibm.com>
Subject: Re: [kvm-unit-tests PATCH v1] s390x: add a pgm irq handler and a way to expect them
Date: Tue, 30 May 2017 10:24:14 +0200	[thread overview]
Message-ID: <f39152fd-8a89-4a66-d6dd-179c10272ec5@redhat.com> (raw)
In-Reply-To: <67569aa2-c95f-e7ac-47dd-ed2939a6c3ae@redhat.com>

On 30.05.2017 10:03, David Hildenbrand wrote:
> On 29.05.2017 18:35, Thomas Huth wrote:
>> On 29.05.2017 14:17, David Hildenbrand wrote:
>>> The pgm irq handler will detect unexpected pgm irqs and allows to
>>> expect pgm irqs + verify that the pgm irq was triggered.
>>>
>>> We need "-fno-delete-null-pointer-checks", otherwise trying to access the
>>> lowcore at address 0 makes GCC generate very weird code.
>>
>> I wonder whether you could get rid of that by using a global variable
>> for lc instead?
> 
> As far as I remember, I tried that and it didn't change a thing. Will do
> a quick test.

It works as long as that global variable is not static, because then GCC
must assume that any other code could set it to !0.

-- 

Thanks,

David

  reply	other threads:[~2017-05-30  8:24 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-29 12:17 [kvm-unit-tests PATCH v1] s390x: add a pgm irq handler and a way to expect them David Hildenbrand
2017-05-29 14:24 ` David Hildenbrand
2017-05-29 16:35 ` Thomas Huth
2017-05-30  8:03   ` David Hildenbrand
2017-05-30  8:24     ` David Hildenbrand [this message]
2017-05-30 10:59     ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f39152fd-8a89-4a66-d6dd-179c10272ec5@redhat.com \
    --to=david@redhat.com \
    --cc=borntraeger@de.ibm.com \
    --cc=kvm@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    --cc=rkrcmar@redhat.com \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox