From: "Garg, Shivank" <shivankg@amd.com>
To: "seanjc@google.com" <seanjc@google.com>
Cc: "jmattson@google.com" <jmattson@google.com>,
"david@kernel.org" <david@kernel.org>,
"ackerleytng@google.com" <ackerleytng@google.com>,
"pshier@google.com" <pshier@google.com>,
"shuah@kernel.org" <shuah@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-kselftest@vger.kernel.org"
<linux-kselftest@vger.kernel.org>,
"pbonzini@redhat.com" <pbonzini@redhat.com>,
"ricarkol@google.com" <ricarkol@google.com>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>
Subject: Re: [PATCH v2 3/4] KVM: selftests: add get_numa_mem_nodes()
Date: Sat, 5 Sep 2026 18:52:18 +0000 [thread overview]
Message-ID: <c15678d5ea8f229d9b7eb8afb1f0a0c94faf8e20.camel@amd.com> (raw)
In-Reply-To: <apbqEfeCQhgdAvKa@google.com>
On Tue, 2026-09-01 at 08:06 -0700, Sean Christopherson wrote:
> On Tue, Sep 01, 2026, Shivank Garg wrote:
> > The xAPIC IPI test uses MPOL_F_MEMS_ALLOWED to get the memory nodes
> > available to the current process. Move the query to numaif.h as
> > get_numa_mem_nodes() so other KVM selftests can use it.
> >
> > Call get_mempolicy() directly instead of using the assert-on-failure
> > kvm_get_mempolicy() wrapper. The xAPIC test already asserts its two
> > node requirement.
>
> NAK. This is not an improvement. get_mempolicy() straight up should not fail
> for this usage.
Agreed. I will drop this patch.
Your kvm_get_numa_memory_nodes() / kvm_get_next_numa_node() helpers are
more useful here.
Thanks,
Shivank
next prev parent reply other threads:[~2026-09-05 18:52 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-01 8:22 [PATCH v2 0/4] KVM: guest_memfd: fix NUMA selftests Shivank Garg
2026-09-01 8:22 ` [PATCH v2 1/4] KVM: selftests: fix maxnode arguments in xapic_ipi_test Shivank Garg
2026-09-01 15:04 ` Sean Christopherson
2026-09-05 9:10 ` Garg, Shivank
2026-09-01 8:22 ` [PATCH v2 2/4] KVM: selftests: use BITS_PER_TYPE() for NUMA masks Shivank Garg
2026-09-01 8:22 ` [PATCH v2 3/4] KVM: selftests: add get_numa_mem_nodes() Shivank Garg
2026-09-01 15:06 ` Sean Christopherson
2026-09-05 18:52 ` Garg, Shivank [this message]
2026-09-01 8:22 ` [PATCH v2 4/4] KVM: selftests: use allowed NUMA nodes in guest_memfd_test Shivank Garg
2026-09-01 8:39 ` sashiko-bot
2026-09-01 9:38 ` Garg, Shivank
2026-09-01 15:07 ` Sean Christopherson
2026-09-01 17:28 ` Sean Christopherson
2026-09-05 19:45 ` Garg, Shivank
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c15678d5ea8f229d9b7eb8afb1f0a0c94faf8e20.camel@amd.com \
--to=shivankg@amd.com \
--cc=ackerleytng@google.com \
--cc=david@kernel.org \
--cc=jmattson@google.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=pshier@google.com \
--cc=ricarkol@google.com \
--cc=seanjc@google.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox