public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
* [kvm-unit-tests PATCH v2 0/4] scripts: Configure and update tools to allow basic b4 usage
@ 2026-04-27 17:36 Christoph Schlameuss
  2026-04-27 17:36 ` [kvm-unit-tests PATCH v2 1/4] scripts/checkpatch.pl: Add empty codespell and const_structs configs Christoph Schlameuss
                   ` (4 more replies)
  0 siblings, 5 replies; 9+ messages in thread
From: Christoph Schlameuss @ 2026-04-27 17:36 UTC (permalink / raw)
  To: kvm
  Cc: Janosch Frank, Paolo Bonzini, Thomas Huth, Andrew Jones,
	Nicholas Piggin, Christoph Schlameuss

Provide some basic configuration for checkpatch.pl so that use on the
command line is less confusing and actually useful.
Checking new patches with i.e. 'b4 prep --check' will now not just give you
dummy errors.

Modify get_maintainer.pl to work when called from 'b4 prep --auto-to-cc'.

---
The second patch also copies the current codespell config from the kernel.
I think this would be nice to have but I would also understand if nobody
wants to add that dead weight here. In that case I would also agree drop
that second patch.

---
Changes in v2:
- corrected variable name to match kernel script
- replace codespell dict with minimal and kvm-unit-tests specific
  version instead of copy form the kernel
- add virtio_config_ops as initial content for const_structs.checkpatch
- add a patch to configure the default b4 prefix

---
Christoph Schlameuss (4):
      scripts/checkpatch.pl: Add empty codespell and const_structs configs
      scripts/checkpatch.pl: Create a project specific codespell config
      scripts/get_maintainer.pl: Ignore --nogit-chief-penguins option
      b4: Add b4 config with default prefix

 .b4-config                       |  2 ++
 scripts/const_structs.checkpatch |  1 +
 scripts/get_maintainer.pl        |  2 ++
 scripts/spelling.txt             | 34 ++++++++++++++++++++++++++++++++++
 4 files changed, 39 insertions(+)
---
base-commit: ea91ac1763561b23e7eba3f7c1fa3d45f29b89be
change-id: 20260423-b4-cmdline-a812ed022659

Best regards,
-- 
Christoph Schlameuss <schlameuss@linux.ibm.com>


^ permalink raw reply	[flat|nested] 9+ messages in thread

* [kvm-unit-tests PATCH v2 1/4] scripts/checkpatch.pl: Add empty codespell and const_structs configs
  2026-04-27 17:36 [kvm-unit-tests PATCH v2 0/4] scripts: Configure and update tools to allow basic b4 usage Christoph Schlameuss
@ 2026-04-27 17:36 ` Christoph Schlameuss
  2026-04-27 17:36 ` [kvm-unit-tests PATCH v2 2/4] scripts/checkpatch.pl: Create a project specific codespell config Christoph Schlameuss
                   ` (3 subsequent siblings)
  4 siblings, 0 replies; 9+ messages in thread
From: Christoph Schlameuss @ 2026-04-27 17:36 UTC (permalink / raw)
  To: kvm
  Cc: Janosch Frank, Paolo Bonzini, Thomas Huth, Andrew Jones,
	Nicholas Piggin, Christoph Schlameuss

Without these files each patch is flagged with these errors providing no
value and swamping actually found warnings and errors:

● xxxxxxxxxxxx: commit title
  ● checkpatch.pl: No typos will be found - file '.../kvm-unit-tests/scripts/spelling.txt': No such file or directory
  ● checkpatch.pl: No structs that should be const will be found - file '.../kvm-unit-tests/scripts/const_structs.checkpatch': No such file or directory

Fixes: 846737f068d9 ("checkpatch support")
Signed-off-by: Christoph Schlameuss <schlameuss@linux.ibm.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
---
 scripts/const_structs.checkpatch | 1 +
 1 file changed, 1 insertion(+)

diff --git a/scripts/const_structs.checkpatch b/scripts/const_structs.checkpatch
new file mode 100644
index 000000000000..6d9ce1d891bc
--- /dev/null
+++ b/scripts/const_structs.checkpatch
@@ -0,0 +1 @@
+virtio_config_ops

-- 
2.53.0


^ permalink raw reply related	[flat|nested] 9+ messages in thread

* [kvm-unit-tests PATCH v2 2/4] scripts/checkpatch.pl: Create a project specific codespell config
  2026-04-27 17:36 [kvm-unit-tests PATCH v2 0/4] scripts: Configure and update tools to allow basic b4 usage Christoph Schlameuss
  2026-04-27 17:36 ` [kvm-unit-tests PATCH v2 1/4] scripts/checkpatch.pl: Add empty codespell and const_structs configs Christoph Schlameuss
@ 2026-04-27 17:36 ` Christoph Schlameuss
  2026-04-28  7:42   ` Thomas Huth
  2026-04-27 17:36 ` [kvm-unit-tests PATCH v2 3/4] scripts/get_maintainer.pl: Ignore --nogit-chief-penguins option Christoph Schlameuss
                   ` (2 subsequent siblings)
  4 siblings, 1 reply; 9+ messages in thread
From: Christoph Schlameuss @ 2026-04-27 17:36 UTC (permalink / raw)
  To: kvm
  Cc: Janosch Frank, Paolo Bonzini, Thomas Huth, Andrew Jones,
	Nicholas Piggin, Christoph Schlameuss

Provide a codespell config to actually let it do something.
Obviously codespell is not happy about the addition of these misspellings
here.

Signed-off-by: Christoph Schlameuss <schlameuss@linux.ibm.com>
---
 scripts/spelling.txt | 34 ++++++++++++++++++++++++++++++++++
 1 file changed, 34 insertions(+)

diff --git a/scripts/spelling.txt b/scripts/spelling.txt
new file mode 100644
index 000000000000..2a5b6195ed21
--- /dev/null
+++ b/scripts/spelling.txt
@@ -0,0 +1,34 @@
+# The format of each line is:
+# mistake||correction
+cpuuid||cpuid
+daig||diag
+epws||epsw
+hcal||hcall
+hypercal||hypercall
+kmv||kvm
+locore||lowcore
+lowcor||lowcore
+mmmu||mmu
+pagetabl||pagetable
+pgtabl||pgtable
+pmcww||pmcw
+qemsystem||qemusystem
+quemu||qemu
+rdsmr||rdmsr
+sapr||spapr
+schipp||schib
+scsww||scsw
+sipg||sigp
+slcp||sclp
+sppar||spapr
+stiss||stsi
+subchanell||subchannel
+subchanel||subchannel
+syscal||syscall
+timbase||timebase
+timeabse||timebase
+tlbb||tlb
+virito||virtio
+vmbc||vmcb
+vmsc||vmcs
+wrsmr||wrmsr

-- 
2.53.0


^ permalink raw reply related	[flat|nested] 9+ messages in thread

* [kvm-unit-tests PATCH v2 3/4] scripts/get_maintainer.pl: Ignore --nogit-chief-penguins option
  2026-04-27 17:36 [kvm-unit-tests PATCH v2 0/4] scripts: Configure and update tools to allow basic b4 usage Christoph Schlameuss
  2026-04-27 17:36 ` [kvm-unit-tests PATCH v2 1/4] scripts/checkpatch.pl: Add empty codespell and const_structs configs Christoph Schlameuss
  2026-04-27 17:36 ` [kvm-unit-tests PATCH v2 2/4] scripts/checkpatch.pl: Create a project specific codespell config Christoph Schlameuss
@ 2026-04-27 17:36 ` Christoph Schlameuss
  2026-05-04  6:53   ` Thomas Huth
  2026-04-27 17:36 ` [kvm-unit-tests PATCH v2 4/4] b4: Add b4 config with default prefix Christoph Schlameuss
  2026-05-04  7:07 ` [kvm-unit-tests PATCH v2 0/4] scripts: Configure and update tools to allow basic b4 usage Thomas Huth
  4 siblings, 1 reply; 9+ messages in thread
From: Christoph Schlameuss @ 2026-04-27 17:36 UTC (permalink / raw)
  To: kvm
  Cc: Janosch Frank, Paolo Bonzini, Thomas Huth, Andrew Jones,
	Nicholas Piggin, Christoph Schlameuss

b4 by default calls the get_maintainer.pl script with the
'--nogit-chief-penguins' option letting the 'b4 prep --auto-to-cc' fail.

Adding parsing of that option without any related functionality to allow
simple usage of b4 in the development workflow.

Signed-off-by: Christoph Schlameuss <schlameuss@linux.ibm.com>

---

Sorry, I am not too versed with perl, so if there are better ways to fix
this please comment.
---
 scripts/get_maintainer.pl | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl
index 117b69145f0e..4d4ff4236f2f 100755
--- a/scripts/get_maintainer.pl
+++ b/scripts/get_maintainer.pl
@@ -31,6 +31,7 @@ my $email_fixes = 1;
 my $email_list = 1;
 my $email_moderated_list = 1;
 my $email_subscriber_list = 0;
+my $email_git_penguin_chiefs = 0;
 my $email_git = 0;
 my $email_git_all_signature_types = 0;
 my $email_git_blame = 0;
@@ -228,6 +229,7 @@ if (!GetOptions(
 		'git-blame!' => \$email_git_blame,
 		'git-blame-signatures!' => \$email_git_blame_signatures,
 		'git-fallback!' => \$email_git_fallback,
+		'git-chief-penguins!' => \$email_git_penguin_chiefs,
 		'git-min-signatures=i' => \$email_git_min_signatures,
 		'git-max-maintainers=i' => \$email_git_max_maintainers,
 		'git-min-percent=i' => \$email_git_min_percent,

-- 
2.53.0


^ permalink raw reply related	[flat|nested] 9+ messages in thread

* [kvm-unit-tests PATCH v2 4/4] b4: Add b4 config with default prefix
  2026-04-27 17:36 [kvm-unit-tests PATCH v2 0/4] scripts: Configure and update tools to allow basic b4 usage Christoph Schlameuss
                   ` (2 preceding siblings ...)
  2026-04-27 17:36 ` [kvm-unit-tests PATCH v2 3/4] scripts/get_maintainer.pl: Ignore --nogit-chief-penguins option Christoph Schlameuss
@ 2026-04-27 17:36 ` Christoph Schlameuss
  2026-05-04  7:01   ` Thomas Huth
  2026-05-04  7:07 ` [kvm-unit-tests PATCH v2 0/4] scripts: Configure and update tools to allow basic b4 usage Thomas Huth
  4 siblings, 1 reply; 9+ messages in thread
From: Christoph Schlameuss @ 2026-04-27 17:36 UTC (permalink / raw)
  To: kvm
  Cc: Janosch Frank, Paolo Bonzini, Thomas Huth, Andrew Jones,
	Nicholas Piggin, Christoph Schlameuss

b4.send-prefixes adds the prefixes when creating a new patch series.

Signed-off-by: Christoph Schlameuss <schlameuss@linux.ibm.com>
---
 .b4-config | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/.b4-config b/.b4-config
new file mode 100644
index 000000000000..b780cc3d4e6f
--- /dev/null
+++ b/.b4-config
@@ -0,0 +1,2 @@
+[b4]
+send-prefixes = kvm-unit-tests

-- 
2.53.0


^ permalink raw reply related	[flat|nested] 9+ messages in thread

* Re: [kvm-unit-tests PATCH v2 2/4] scripts/checkpatch.pl: Create a project specific codespell config
  2026-04-27 17:36 ` [kvm-unit-tests PATCH v2 2/4] scripts/checkpatch.pl: Create a project specific codespell config Christoph Schlameuss
@ 2026-04-28  7:42   ` Thomas Huth
  0 siblings, 0 replies; 9+ messages in thread
From: Thomas Huth @ 2026-04-28  7:42 UTC (permalink / raw)
  To: Christoph Schlameuss, kvm
  Cc: Janosch Frank, Paolo Bonzini, Andrew Jones, Nicholas Piggin

On 27/04/2026 19.36, Christoph Schlameuss wrote:
> Provide a codespell config to actually let it do something.
> Obviously codespell is not happy about the addition of these misspellings
> here.
> 
> Signed-off-by: Christoph Schlameuss <schlameuss@linux.ibm.com>
> ---
>   scripts/spelling.txt | 34 ++++++++++++++++++++++++++++++++++
>   1 file changed, 34 insertions(+)

Reviewed-by: Thomas Huth <thuth@redhat.com>


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [kvm-unit-tests PATCH v2 3/4] scripts/get_maintainer.pl: Ignore --nogit-chief-penguins option
  2026-04-27 17:36 ` [kvm-unit-tests PATCH v2 3/4] scripts/get_maintainer.pl: Ignore --nogit-chief-penguins option Christoph Schlameuss
@ 2026-05-04  6:53   ` Thomas Huth
  0 siblings, 0 replies; 9+ messages in thread
From: Thomas Huth @ 2026-05-04  6:53 UTC (permalink / raw)
  To: Christoph Schlameuss, kvm
  Cc: Janosch Frank, Paolo Bonzini, Andrew Jones, Nicholas Piggin

On 27/04/2026 19.36, Christoph Schlameuss wrote:
> b4 by default calls the get_maintainer.pl script with the
> '--nogit-chief-penguins' option letting the 'b4 prep --auto-to-cc' fail.
> 
> Adding parsing of that option without any related functionality to allow
> simple usage of b4 in the development workflow.
> 
> Signed-off-by: Christoph Schlameuss <schlameuss@linux.ibm.com>
> 
> ---
> 
> Sorry, I am not too versed with perl, so if there are better ways to fix
> this please comment.
> ---
>   scripts/get_maintainer.pl | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl
> index 117b69145f0e..4d4ff4236f2f 100755
> --- a/scripts/get_maintainer.pl
> +++ b/scripts/get_maintainer.pl
> @@ -31,6 +31,7 @@ my $email_fixes = 1;
>   my $email_list = 1;
>   my $email_moderated_list = 1;
>   my $email_subscriber_list = 0;
> +my $email_git_penguin_chiefs = 0;
>   my $email_git = 0;
>   my $email_git_all_signature_types = 0;
>   my $email_git_blame = 0;
> @@ -228,6 +229,7 @@ if (!GetOptions(
>   		'git-blame!' => \$email_git_blame,
>   		'git-blame-signatures!' => \$email_git_blame_signatures,
>   		'git-fallback!' => \$email_git_fallback,
> +		'git-chief-penguins!' => \$email_git_penguin_chiefs,
>   		'git-min-signatures=i' => \$email_git_min_signatures,
>   		'git-max-maintainers=i' => \$email_git_max_maintainers,
>   		'git-min-percent=i' => \$email_git_min_percent,
> 

Reviewed-by: Thomas Huth <thuth@redhat.com>


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [kvm-unit-tests PATCH v2 4/4] b4: Add b4 config with default prefix
  2026-04-27 17:36 ` [kvm-unit-tests PATCH v2 4/4] b4: Add b4 config with default prefix Christoph Schlameuss
@ 2026-05-04  7:01   ` Thomas Huth
  0 siblings, 0 replies; 9+ messages in thread
From: Thomas Huth @ 2026-05-04  7:01 UTC (permalink / raw)
  To: Christoph Schlameuss, kvm
  Cc: Janosch Frank, Paolo Bonzini, Andrew Jones, Nicholas Piggin

On 27/04/2026 19.36, Christoph Schlameuss wrote:
> b4.send-prefixes adds the prefixes when creating a new patch series.
> 
> Signed-off-by: Christoph Schlameuss <schlameuss@linux.ibm.com>
> ---
>   .b4-config | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/.b4-config b/.b4-config
> new file mode 100644
> index 000000000000..b780cc3d4e6f
> --- /dev/null
> +++ b/.b4-config
> @@ -0,0 +1,2 @@
> +[b4]
> +send-prefixes = kvm-unit-tests

Reviewed-by: Thomas Huth <thuth@redhat.com>


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [kvm-unit-tests PATCH v2 0/4] scripts: Configure and update tools to allow basic b4 usage
  2026-04-27 17:36 [kvm-unit-tests PATCH v2 0/4] scripts: Configure and update tools to allow basic b4 usage Christoph Schlameuss
                   ` (3 preceding siblings ...)
  2026-04-27 17:36 ` [kvm-unit-tests PATCH v2 4/4] b4: Add b4 config with default prefix Christoph Schlameuss
@ 2026-05-04  7:07 ` Thomas Huth
  4 siblings, 0 replies; 9+ messages in thread
From: Thomas Huth @ 2026-05-04  7:07 UTC (permalink / raw)
  To: Christoph Schlameuss, kvm
  Cc: Janosch Frank, Paolo Bonzini, Andrew Jones, Nicholas Piggin

On 27/04/2026 19.36, Christoph Schlameuss wrote:
> Provide some basic configuration for checkpatch.pl so that use on the
> command line is less confusing and actually useful.
> Checking new patches with i.e. 'b4 prep --check' will now not just give you
> dummy errors.
> 
> Modify get_maintainer.pl to work when called from 'b4 prep --auto-to-cc'.

Thanks, applied now!

  Thomas


^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2026-05-04  7:07 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-04-27 17:36 [kvm-unit-tests PATCH v2 0/4] scripts: Configure and update tools to allow basic b4 usage Christoph Schlameuss
2026-04-27 17:36 ` [kvm-unit-tests PATCH v2 1/4] scripts/checkpatch.pl: Add empty codespell and const_structs configs Christoph Schlameuss
2026-04-27 17:36 ` [kvm-unit-tests PATCH v2 2/4] scripts/checkpatch.pl: Create a project specific codespell config Christoph Schlameuss
2026-04-28  7:42   ` Thomas Huth
2026-04-27 17:36 ` [kvm-unit-tests PATCH v2 3/4] scripts/get_maintainer.pl: Ignore --nogit-chief-penguins option Christoph Schlameuss
2026-05-04  6:53   ` Thomas Huth
2026-04-27 17:36 ` [kvm-unit-tests PATCH v2 4/4] b4: Add b4 config with default prefix Christoph Schlameuss
2026-05-04  7:01   ` Thomas Huth
2026-05-04  7:07 ` [kvm-unit-tests PATCH v2 0/4] scripts: Configure and update tools to allow basic b4 usage Thomas Huth

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox