From: "Huang, Kai" <kai.huang@intel.com>
To: Paolo Bonzini <pbonzini@redhat.com>,
<linux-kernel@vger.kernel.org>, <kvm@vger.kernel.org>
Cc: Zixi Chen <zixchen@redhat.com>, Adam Dunlap <acdunlap@google.com>,
"Kirill A . Shutemov" <kirill.shutemov@linux.intel.com>,
Xiaoyao Li <xiaoyao.li@intel.com>,
Dave Hansen <dave.hansen@linux.intel.com>,
"Thomas Gleixner" <tglx@linutronix.de>,
Ingo Molnar <mingo@kernel.org>, <x86@kernel.org>,
<stable@vger.kernel.org>
Subject: Re: [PATCH v2 2/2] x86/cpu/intel: Detect TME keyid bits before setting MTRR mask registers
Date: Thu, 1 Feb 2024 23:42:45 +0800 [thread overview]
Message-ID: <d2ff1f95-709b-4dbd-b0a0-639193f18c2c@intel.com> (raw)
In-Reply-To: <20240131230902.1867092-3-pbonzini@redhat.com>
> static void early_init_intel(struct cpuinfo_x86 *c)
> {
> u64 misc_enable;
> @@ -322,6 +406,13 @@ static void early_init_intel(struct cpuinfo_x86 *c)
> */
> if (detect_extended_topology_early(c) < 0)
> detect_ht_early(c);
> +
> + /*
> + * Adjust the number of physical bits early because it affects the
> + * valid bits of the MTRR mask registers.
> + */
> + if (cpu_has(c, X86_FEATURE_TME))
> + detect_tme_early(c);
> }
>
early_init_intel() is also called by init_intel(), so IIUC for BSP
detect_tme_early() will be called twice.
But this is no harm AFAICT, so:
Acked-by: Kai Huang <kai.huang@intel.com>
next prev parent reply other threads:[~2024-02-01 15:43 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-31 23:09 [PATCH v2 0/2] x86/cpu: fix invalid MTRR mask values for SEV or TME Paolo Bonzini
2024-01-31 23:09 ` [PATCH v2 1/2] x86/cpu: allow reducing x86_phys_bits during early_identify_cpu() Paolo Bonzini
2024-02-01 8:33 ` Kirill A . Shutemov
2024-02-01 15:44 ` Huang, Kai
2024-01-31 23:09 ` [PATCH v2 2/2] x86/cpu/intel: Detect TME keyid bits before setting MTRR mask registers Paolo Bonzini
2024-02-01 8:34 ` Kirill A . Shutemov
2024-02-01 15:42 ` Huang, Kai [this message]
2024-02-01 18:29 ` [PATCH v2 0/2] x86/cpu: fix invalid MTRR mask values for SEV or TME Dave Hansen
2024-02-01 21:42 ` Dave Hansen
2024-02-01 23:08 ` Paolo Bonzini
2024-02-04 17:21 ` Paolo Bonzini
2024-02-13 15:45 ` Paolo Bonzini
2024-02-13 22:02 ` Dave Hansen
2024-02-13 22:25 ` Paolo Bonzini
2024-02-20 12:22 ` Paolo Bonzini
2024-02-22 18:06 ` Dave Hansen
2024-02-22 18:08 ` Paolo Bonzini
2024-02-26 1:57 ` Yin Fengwei
2024-02-26 16:21 ` Dave Hansen
2024-02-27 2:02 ` Yin Fengwei
2024-02-27 6:08 ` Yin Fengwei
2024-02-27 13:30 ` Dave Hansen
2024-02-28 0:07 ` Yin Fengwei
2024-02-13 17:07 ` Dave Hansen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d2ff1f95-709b-4dbd-b0a0-639193f18c2c@intel.com \
--to=kai.huang@intel.com \
--cc=acdunlap@google.com \
--cc=dave.hansen@linux.intel.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=pbonzini@redhat.com \
--cc=stable@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=xiaoyao.li@intel.com \
--cc=zixchen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox